Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenChrom trademark #1685

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Conversation

Mailaender
Copy link
Contributor

like #860 did.

@eselmeister
Copy link
Contributor

Isn't a correct automatic module name required?

org.eclipse.chemclipse.xxd.identifier.supplier.wikidata.ui
...

@Mailaender
Copy link
Contributor Author

Apparently not when it was the wrong one all the time.

@eselmeister
Copy link
Contributor

Probably, it's better to set the correct one instead of none to be consistent with all other bundles.

@Mailaender
Copy link
Contributor Author

Fixed it in a few other occasions.

@eselmeister eselmeister merged commit e002d59 into eclipse:develop Mar 10, 2024
3 checks passed
@Mailaender Mailaender deleted the rm-openchrom branch March 10, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants