Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Always perform local docker login in 'cwctl registrysecrets add' #2582

Closed
hhellyer opened this issue Apr 1, 2020 · 3 comments
Closed

Always perform local docker login in 'cwctl registrysecrets add' #2582

hhellyer opened this issue Apr 1, 2020 · 3 comments
Assignees
Labels
area/docs Improvements or additions to documentation area/portal kind/bug

Comments

@hhellyer
Copy link
Contributor

hhellyer commented Apr 1, 2020

Codewind version:
OS: All

Description:
At the moment when the command cwctl registrysecrets add is run we do a local docker login if the secret is being added to a local connection.
As discussed here: #1306 (comment) we should change this so we always do the local docker login whether we are working with a local or remote connection. This will be more consistent and let us simplify the docs when using appsody.

This is a small fix as we just need to move the code in cwctl but we should make sure this change is reflected in the docs once we have completed it.

Workaround:
Currently (as documented) the user needs to run docker login manually to make sure appsody init works for projects building on a remote instance of codewind.

@hhellyer
Copy link
Contributor Author

hhellyer commented Apr 1, 2020

This has been added to eclipse-archived/codewind-installer#414 as that hasn't been merged yet.

@codewind-bot
Copy link

@hhellyer - this issue is now ready to be verified.

@hhellyer hhellyer self-assigned this Apr 7, 2020
@hhellyer
Copy link
Contributor Author

hhellyer commented Apr 8, 2020

This is done, we always do the docker login whatever the path and the docs reflect this. (It was writing the docs that highlighted this issue in the first place.)

@hhellyer hhellyer closed this as completed Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Improvements or additions to documentation area/portal kind/bug
Projects
None yet
Development

No branches or pull requests

2 participants