Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish maven plugin #45

Closed
akurtakov opened this issue Jan 5, 2021 · 18 comments
Closed

Publish maven plugin #45

akurtakov opened this issue Jan 5, 2021 · 18 comments

Comments

@akurtakov
Copy link
Contributor

In order to be able to use the new maven-plugin it has to be published to maven repository. It's too early to think of maven central so probably https://repo.eclipse.org/ is best.

msohn added a commit to msohn/dash-licenses that referenced this issue Jan 6, 2021
Bug: eclipse-dash#45
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
@msohn
Copy link
Contributor

msohn commented Jan 6, 2021

Pushed #48 for review.
Someone with access to the build configuration needs to configure Maven to run the deploy phase.
And maybe some configuration is needed to grant acccess to Nexus to the Jiro instance used by dash.

@waynebeaton
Copy link
Collaborator

Any volunteers?

Unfortunately, I've never done any of the above and am starting from zero knowledge.

@akurtakov
Copy link
Contributor Author

Is there JIPP for dash?

@waynebeaton
Copy link
Collaborator

There is. I guess that I have some homework to do.

@waynebeaton
Copy link
Collaborator

I've created a build. I'll try to sort out how to push the results to repo.eclipse.org later this afternoon.

@msohn
Copy link
Contributor

msohn commented Jan 14, 2021

I guess Fred knows how to configure that

@waynebeaton
Copy link
Collaborator

I've requested some space on repo.eclipse.org.

@waynebeaton
Copy link
Collaborator

I guess Fred knows how to configure that

That's a pretty good guess. :-)

@msohn
Copy link
Contributor

msohn commented Jan 24, 2021

here is the documentation how to deploy build artefacts to repo.eclipse.org
https://wiki.eclipse.org/Jenkins#How_can_artifacts_be_deployed_to_Nexus_OSS_.28repo.eclipse.org.29.3F

@waynebeaton
Copy link
Collaborator

Deployed. Look here.

The job is currently configured to run manually.

@msohn
Copy link
Contributor

msohn commented Jan 25, 2021

I tried to run this on the jgit project but the plugin can't be run since jgit is still compiled using java 8 since there are a lot of consumers which can't cope with java 11 yet.

Could you compile the maven plugin using java 8 ?

@waynebeaton
Copy link
Collaborator

Could you compile the maven plugin using java 8 ?

Sorry for the delay. I tried and I failed.

It fails to compile because we're using some classes introduced in Java 11 (e.g., java.net.http.HttpResponse).

My sense is that we still have a significant number of projects still building on Java 8 and that we should address this. The original code ran using Apache HttpClient. I'll investigate reverting to that.

@msohn
Copy link
Contributor

msohn commented Jan 27, 2021

thanks

in the interim until this is available we can run
mvn org.eclipse.dash:license-tool-plugin:license-check -Ddash.summary=DEPENDENCIES
using Java 11 after running the actual jgit build using java 8

@waynebeaton
Copy link
Collaborator

So... dumb question, but I can't seem to quite sort out the magic myself.

How do I pull the plugin from repo.eclipse.org and invoke the plugin from the CLI? I'm trying to set the -Dmaven.repo.remote to point to repo.eclipse.org, but can't get it work.

$ mvn org.eclipse.dash:license-tool-plugin:license-check -Dmaven.repo.remote=http://repo.eclipse.org/content/repositories/snapshots/ -Dmaven.repo.local=/tmp/mvn
...
[ERROR] Plugin org.eclipse.dash:license-tool-plugin:license-check or one of its dependencies could not be resolved

(I'm pointing the local repo into /tmp to avoid it picking up the version of the plugin that I've installed in my local repo).

@akurtakov
Copy link
Contributor Author

You have to define it as pluginRepository and unfortunately I'm not aware of a way to do it via cli so pom.xml has to define it.

@akurtakov
Copy link
Contributor Author

Done and I use it in lsp4e and tycho.

@waynebeaton
Copy link
Collaborator

Reopening. I regard "publishing" as making available on Maven Central.

I think that we need to enable committers to just mvn org.eclipse.dash:license-tool-plugin:license-check and have magic happen.

@waynebeaton
Copy link
Collaborator

I've changed my mind. This is a speciality tool (at least for now). Expanding access to a broader audience isn't a goal. Unless somebody can convince me otherwise, I no longer regard publishing to Maven Central as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants