Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnist refactoring #9612

Merged
merged 8 commits into from Jan 24, 2022
Merged

Mnist refactoring #9612

merged 8 commits into from Jan 24, 2022

Conversation

agibsonccc
Copy link
Contributor

What changes were proposed in this pull request?

Fixes up mnist data fetchers to allow specifying a top level directory.
This will allow faster performance and easier use of the fetchers avoiding
directory collisions during test performance.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

Quick checklist

The following checklist helps ensure your PR is complete:

  • [ X] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • [ X] Reviewed the Contributing Guidelines and followed the steps within.
  • [ X] Created tests for any significant new code additions.
  • [X ] Relevant tests for your changes are passing.

@agibsonccc agibsonccc requested a review from treo January 24, 2022 10:44
@agibsonccc agibsonccc merged commit 43725c0 into master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants