End-2-end acks for Ditto Java Client #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….xml in order to have it included in required bundles Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
* Added missing null-checks. * Removed superfluous null-checks to make fluent API more fluent. * Made constructors private as the builder should not be directly instantiated. Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…the "ditto-signals-acks" module in 2 Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…e_ack Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…akage check Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…onal header, use it in the local sessionId, otherwise send along the generated local session id as "correlation-id" header and therefore client session identifier Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…custom "acknowledgements" whenever processing "Changes" (which are created from subscribed ThingEvents) * enhanced Change by extending WithDittoHeaders * added a TODO to solve once the search is added to the Ditto Client in order to reduce merge conflicts Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…he possibility to specify DittoHeaders as Options * supported handling "Acknowledgements" CommandResponses and extract the "twin-persisted" part of them interpreting them as "normal" CommandResponse * renamed sendSignal() to emitSignal() in MessagingProvider to use the same term as in search feature branch Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io> Conflicts: java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableThingChange.java java/src/main/java/org/eclipse/ditto/client/configuration/WebSocketMessagingConfiguration.java java/src/main/java/org/eclipse/ditto/client/internal/CommonManagementImpl.java java/src/main/java/org/eclipse/ditto/client/internal/DefaultDittoClient.java java/src/main/java/org/eclipse/ditto/client/internal/SendTerminator.java java/src/main/java/org/eclipse/ditto/client/management/internal/FeatureHandleImpl.java java/src/main/java/org/eclipse/ditto/client/messaging/MessagingProvider.java java/src/main/java/org/eclipse/ditto/client/messaging/internal/WebSocketMessagingProvider.java java/src/test/java/org/eclipse/ditto/client/internal/SendTerminatorTest.java java/src/test/java/org/eclipse/ditto/client/messaging/mock/MockMessagingProvider.java
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…t.testEventAcknowledgement test as `channel` can't be "live" due to assertJ Assumption Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
… feature + attribute commands as well Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
… by specificity; remove unreachable branch; add a test for feature acknowledgement requests. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…to their status code. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…imeException Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…ons.headers() Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…amples Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
…ded when sending/replying to a message * fixed critical bug in PendingMessageImpl which caused a non-visible ClassCastException for message responses using the typed message send() API Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
yufei-cai
force-pushed
the
feature/e2e_ack
branch
from
006582e
to
4b25736
Compare
|
Should build after merging eclipse-ditto/ditto#655 |
…ls-acks-things is required Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to eclipse-ditto/ditto#611
Adds end-2-end acknowledgement support to the Ditto Java Client:
Changesin the Client)