Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Exercise solutions link for company-kata to EC kata slides #123

Closed
prathasirisha opened this issue May 19, 2020 · 7 comments
Closed

Update Exercise solutions link for company-kata to EC kata slides #123

prathasirisha opened this issue May 19, 2020 · 7 comments
Assignees
@ScottBNYM

Comments

@prathasirisha
Copy link
Contributor

prathasirisha commented May 19, 2020 •
edited
Loading

Add solutions links to Company kata slides
@donraab
Copy link
Contributor

donraab commented May 19, 2020 •
edited
Loading

Hi @prathasirisha, thanks for adding the issue. I think we could just have one issue for all of the solutions.

@nikhilnanivadekar
Copy link
Contributor

Why add any solutions to the slides? We should just have a placeholder at the start or in read me.

@donraab
Copy link
Contributor

donraab commented May 19, 2020

We currently have slides at the end of each section that link to the solutions. This is just correcting the links to the new solutions so we can delete the branch.

@nikhilnanivadekar
Copy link
Contributor

Ah! Got it! I for some reason thought porting over all the code of solutions

@prathasirisha prathasirisha changed the title Add Exercise 1 solutions from company-kata to EC kata slides Update Exercise solutions link for company-kata to EC kata slides May 19, 2020
@prathasirisha
Copy link
Contributor Author

Updated issue description based your comments.

@ScottBNYM
Copy link
Contributor

Hi Don, I really want to work on this issue... @donraab

@donraab donraab assigned donraab and ScottBNYM and unassigned donraab Jul 15, 2020
@donraab
Copy link
Contributor

donraab commented Jul 15, 2020

Ok, thanks for volunteering @ScottBNYM! I assigned the ticket to you.

ScottBNYM added a commit to ScottBNYM/eclipse-collections-kata that referenced this issue Jul 16, 2020
@ScottBNYM
Closes eclipse#123: Updated links to solutions.
d82f867 
Signed-off-by: Richard Scott <richard.scott@bnymellon.com>
donraab added a commit that referenced this issue Jul 16, 2020
@donraab
Merge pull request #142 from ScottBNYM/master
5a0dde2 
Closes #123: Updated links to solutions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottBNYM ScottBNYM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@donraab @nikhilnanivadekar @prathasirisha @ScottBNYM