Turn on additional IntelliJ inspections and fix violations (Trivial I…

…f). #1323 Signed-off-by: Alexander Goldberg <alexander.goldberg@bnymellon.com>
eclipse · Jan 13, 2023 · 48b73f0 · 48b73f0
1 parent 412d842
commit 48b73f0
Show file tree

Hide file tree

Showing 13 changed files with 22 additions and 68 deletions.
diff --git a/.idea/inspectionProfiles/3_Consistent_Style.xml b/.idea/inspectionProfiles/3_Consistent_Style.xml
diff --git a/.idea/inspectionProfiles/IDE.xml b/.idea/inspectionProfiles/IDE.xml
diff --git a/...ctions/src/main/java/org/eclipse/collections/impl/bimap/mutable/AbstractMutableBiMap.java b/...ctions/src/main/java/org/eclipse/collections/impl/bimap/mutable/AbstractMutableBiMap.java
@@ -115,16 +115,12 @@ private static boolean nullSafeEquals(Object value, Object other)
     {
         if (value == null)
         {
-            if (other == null)
-            {
-                return true;
-            }
+            return other == null;
         }
-        else if (other == value || value.equals(other))
+        else
         {
-            return true;
+            return other == value || value.equals(other);
         }
-        return false;
     }
 
     @Override

diff --git a/...collections/src/main/java/org/eclipse/collections/impl/map/mutable/ConcurrentHashMap.java b/...collections/src/main/java/org/eclipse/collections/impl/map/mutable/ConcurrentHashMap.java
@@ -1856,10 +1856,7 @@ public boolean equals(Object o)
             {
                 V v1 = this.value;
                 Object v2 = e.getValue();
-                if (v1 == v2 || v1 != null && v1.equals(v2))
-                {
-                    return true;
-                }
+                return v1 == v2 || v1 != null && v1.equals(v2);
             }
             return false;
         }

diff --git a/...tions/src/main/java/org/eclipse/collections/impl/map/mutable/ConcurrentHashMapUnsafe.java b/...tions/src/main/java/org/eclipse/collections/impl/map/mutable/ConcurrentHashMapUnsafe.java
@@ -1969,10 +1969,7 @@ public boolean equals(Object o)
             {
                 V v1 = this.value;
                 Object v2 = e.getValue();
-                if (v1 == v2 || v1 != null && v1.equals(v2))
-                {
-                    return true;
-                }
+                return v1 == v2 || v1 != null && v1.equals(v2);
             }
             return false;
         }

diff --git a/eclipse-collections/src/main/java/org/eclipse/collections/impl/map/mutable/UnifiedMap.java b/eclipse-collections/src/main/java/org/eclipse/collections/impl/map/mutable/UnifiedMap.java
@@ -2539,16 +2539,12 @@ private static boolean nullSafeEquals(Object value, Object other)
     {
         if (value == null)
         {
-            if (other == null)
-            {
-                return true;
-            }
+            return other == null;
         }
-        else if (other == value || value.equals(other))
+        else
         {
-            return true;
+            return other == value || value.equals(other);
         }
-        return false;
     }
 
     protected class EntrySet implements Set<Entry<K, V>>, Serializable, BatchIterable<Entry<K, V>>

diff --git a/...rc/main/java/org/eclipse/collections/impl/map/mutable/primitive/ObjectBooleanHashMap.java b/...rc/main/java/org/eclipse/collections/impl/map/mutable/primitive/ObjectBooleanHashMap.java
@@ -1053,16 +1053,12 @@ private static boolean nullSafeEquals(Object value, Object other)
     {
         if (value == null)
         {
-            if (other == null)
-            {
-                return true;
-            }
+            return other == null;
         }
-        else if (other == value || value.equals(other))
+        else
         {
-            return true;
+            return other == value || value.equals(other);
         }
-        return false;
     }
 
     private K toNonSentinel(Object key)

diff --git a/...lipse/collections/impl/map/mutable/primitive/ObjectBooleanHashMapWithHashingStrategy.java b/...lipse/collections/impl/map/mutable/primitive/ObjectBooleanHashMapWithHashingStrategy.java
@@ -1072,17 +1072,11 @@ private boolean nullSafeEquals(K key, Object other)
     {
         if (key == null)
         {
-            if (other == null)
-            {
-                return true;
-            }
+            return other == null;
         }
         else if (key != NULL_KEY && other != null)
         {
-            if (this.hashingStrategy.equals(key, this.toNonSentinel(other)))
-            {
-                return true;
-            }
+            return this.hashingStrategy.equals(key, this.toNonSentinel(other));
         }
         return false;
     }

diff --git a/...java/org/eclipse/collections/impl/map/strategy/mutable/UnifiedMapWithHashingStrategy.java b/...java/org/eclipse/collections/impl/map/strategy/mutable/UnifiedMapWithHashingStrategy.java
@@ -2268,16 +2268,12 @@ private static boolean nullSafeEquals(Object value, Object other)
     {
         if (value == null)
         {
-            if (other == null)
-            {
-                return true;
-            }
+            return other == null;
         }
-        else if (other == value || value.equals(other))
+        else
         {
-            return true;
+            return other == value || value.equals(other);
         }
-        return false;
     }
 
     protected class EntrySet implements Set<Entry<K, V>>, Serializable, BatchIterable<Entry<K, V>>

diff --git a/...ections/src/main/java/org/eclipse/collections/impl/string/immutable/CodePointAdapter.java b/...ections/src/main/java/org/eclipse/collections/impl/string/immutable/CodePointAdapter.java
@@ -702,11 +702,7 @@ public boolean equalsIntList(IntList list)
             }
             i += Character.charCount(codePoint);
         }
-        if (size < list.size())
-        {
-            return false;
-        }
-        return true;
+        return size >= list.size();
     }
 
     private boolean equalsCodePointAdapter(CodePointAdapter adapter)

diff --git a/unit-tests-java8/src/test/java/org/eclipse/collections/test/domain/B.java b/unit-tests-java8/src/test/java/org/eclipse/collections/test/domain/B.java
@@ -45,12 +45,7 @@ public boolean equals(Object o)
 
         B b = (B) o;
 
-        if (this.i != b.i)
-        {
-            return false;
-        }
-
-        return true;
+        return this.i == b.i;
     }
 
     @Override

diff --git a/unit-tests-java8/src/test/java/org/eclipse/collections/test/domain/C.java b/unit-tests-java8/src/test/java/org/eclipse/collections/test/domain/C.java
@@ -45,12 +45,7 @@ public boolean equals(Object o)
 
         C c = (C) o;
 
-        if (Double.compare(c.d, this.d) != 0)
-        {
-            return false;
-        }
-
-        return true;
+        return Double.compare(c.d, this.d) == 0;
     }
 
     @Override

diff --git a/unit-tests/src/test/java/org/eclipse/collections/impl/test/domain/Person.java b/unit-tests/src/test/java/org/eclipse/collections/impl/test/domain/Person.java
@@ -61,12 +61,7 @@ public boolean equals(Object o)
         {
             return false;
         }
-        if (!this.lastName.equals(person.lastName))
-        {
-            return false;
-        }
-
-        return true;
+        return this.lastName.equals(person.lastName);
     }
 
     @Override