Replace FastList.newList(iterable) with Lists.mutable.withAll().

eclipse · Apr 12, 2022 · ce97a57 · ce97a57
1 parent 8702946
commit ce97a57
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 8 deletions.
diff --git a/.idea/inspectionProfiles/IDE.xml b/.idea/inspectionProfiles/IDE.xml
diff --git a/...ions/src/main/java/org/eclipse/collections/impl/collection/mutable/CollectionAdapter.java b/...ions/src/main/java/org/eclipse/collections/impl/collection/mutable/CollectionAdapter.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021 Goldman Sachs.
+ * Copyright (c) 2022 Goldman Sachs and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * and Eclipse Distribution License v. 1.0 which accompany this distribution.
@@ -117,7 +117,7 @@ public static <E> MutableList<E> wrapList(Iterable<E> iterable)
         {
             return ListAdapter.adapt((List<E>) iterable);
         }
-        return FastList.newList(iterable);
+        return Lists.mutable.withAll(iterable);
     }
 
     public static <E> MutableCollection<E> adapt(Collection<E> collection)

diff --git a/...lections/src/main/java/org/eclipse/collections/impl/list/mutable/AbstractMutableList.java b/...lections/src/main/java/org/eclipse/collections/impl/list/mutable/AbstractMutableList.java
@@ -670,12 +670,12 @@ protected SubList(AbstractMutableList<T> list, int fromIndex, int toIndex)
         @Override
         public MutableList<T> toReversed()
         {
-            return FastList.newList(this).reverseThis();
+            return Lists.mutable.withAll(this).reverseThis();
         }
 
         protected Object writeReplace()
         {
-            return FastList.newList(this);
+            return Lists.mutable.withAll(this);
         }
 
         @Override

diff --git a/eclipse-collections/src/main/java/org/eclipse/collections/impl/list/mutable/ListAdapter.java b/eclipse-collections/src/main/java/org/eclipse/collections/impl/list/mutable/ListAdapter.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021 Goldman Sachs and others.
+ * Copyright (c) 2022 Goldman Sachs and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * and Eclipse Distribution License v. 1.0 which accompany this distribution.
@@ -106,7 +106,7 @@ public MutableList<T> asSynchronized()
     @Override
     public MutableList<T> clone()
     {
-        return FastList.newList(this.delegate);
+        return Lists.mutable.withAll(this.delegate);
     }
 
     /**

diff --git a/...tions/src/main/java/org/eclipse/collections/impl/list/mutable/MutableListFactoryImpl.java b/...tions/src/main/java/org/eclipse/collections/impl/list/mutable/MutableListFactoryImpl.java
@@ -54,6 +54,7 @@ public <T> MutableList<T> withInitialCapacity(int capacity)
     @Override
     public <T> MutableList<T> withAll(Iterable<? extends T> iterable)
     {
+        //noinspection SSBasedInspection
         return FastList.newList(iterable);
     }
 

diff --git a/...ions/src/main/java/org/eclipse/collections/impl/list/mutable/RandomAccessListAdapter.java b/...ions/src/main/java/org/eclipse/collections/impl/list/mutable/RandomAccessListAdapter.java
@@ -118,7 +118,7 @@ public MutableList<T> asSynchronized()
     @Override
     public MutableList<T> clone()
     {
-        return FastList.newList(this.delegate);
+        return Lists.mutable.withAll(this.delegate);
     }
 
     /**

diff --git a/eclipse-collections/src/main/java/org/eclipse/collections/impl/utility/Iterate.java b/eclipse-collections/src/main/java/org/eclipse/collections/impl/utility/Iterate.java
@@ -3195,7 +3195,7 @@ public static <T extends Comparable<? super T>> MutableList<T> toSortedList(Iter
      */
     public static <T> MutableList<T> toSortedList(Iterable<T> iterable, Comparator<? super T> comparator)
     {
-        return FastList.newList(iterable).sortThis(comparator);
+        return Lists.mutable.withAll(iterable).sortThis(comparator);
     }
 
     /**