Remove extra calls to map.get in sumByDoubleFunction and sumByFloatFu…

…nction. Signed-off-by: Donald Raab <Donald.Raab@bnymellon.com>
eclipse · Sep 14, 2020 · de17f10 · de17f10
1 parent c9c84ba
commit de17f10
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...lections/src/main/java/org/eclipse/collections/impl/block/factory/PrimitiveFunctions.java b/...lections/src/main/java/org/eclipse/collections/impl/block/factory/PrimitiveFunctions.java
@@ -142,8 +142,9 @@ public MutableObjectDoubleMap<V> value(MutableObjectDoubleMap<V> map, T each)
                 V groupKey = groupBy.valueOf(each);
                 double compensation = this.compensation.getIfAbsent(groupKey, 0.0d);
                 double adjustedValue = function.floatValueOf(each) - compensation;
-                double nextSum = map.get(groupKey) + adjustedValue;
-                this.compensation.put(groupKey, nextSum - map.get(groupKey) - adjustedValue);
+                double currentSum = map.get(groupKey);
+                double nextSum = currentSum + adjustedValue;
+                this.compensation.put(groupKey, nextSum - currentSum - adjustedValue);
                 map.put(groupKey, nextSum);
                 return map;
             }
@@ -176,8 +177,9 @@ public MutableObjectDoubleMap<V> value(MutableObjectDoubleMap<V> map, T each)
                 V groupKey = groupBy.valueOf(each);
                 double compensation = this.compensation.getIfAbsent(groupKey, 0.0d);
                 double adjustedValue = function.doubleValueOf(each) - compensation;
-                double nextSum = map.get(groupKey) + adjustedValue;
-                this.compensation.put(groupKey, nextSum - map.get(groupKey) - adjustedValue);
+                double currentSum = map.get(groupKey);
+                double nextSum = currentSum + adjustedValue;
+                this.compensation.put(groupKey, nextSum - currentSum - adjustedValue);
                 map.put(groupKey, nextSum);
                 return map;
             }