Optimize List.clear methods to avoid clearing unused memory

Fixes goldmansachs/gs-collections#33 Signed-off-by: Christopher Clark <csquared@cs.washington.edu>
eclipse · Sep 26, 2016 · ec1fd2a · ec1fd2a
1 parent 0db19cf
commit ec1fd2a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...se-collections-code-generator/src/main/resources/impl/list/mutable/primitiveArrayList.stg b/...se-collections-code-generator/src/main/resources/impl/list/mutable/primitiveArrayList.stg
@@ -109,7 +109,7 @@ public class <name>ArrayList extends Abstract<name>Iterable
 
     public void clear()
     {
-        Arrays.fill(this.items, <(zero.(type))>);
+        Arrays.fill(this.items, 0, size, <(zero.(type))>);
         this.size = 0;
     }
 

diff --git a/eclipse-collections/src/main/java/org/eclipse/collections/impl/list/mutable/FastList.java b/eclipse-collections/src/main/java/org/eclipse/collections/impl/list/mutable/FastList.java
@@ -215,7 +215,7 @@ public FastList<T> clone()
     @Override
     public void clear()
     {
-        Arrays.fill(this.items, null);
+        Arrays.fill(this.items, 0, size, null);
         this.size = 0;
     }