Please properly license and sign the artifacts contributed to the release train. #763
Comments
|
@merks yes we will need help to resolve this. None of us maintainers are eclipse experts, so it would be great if you could tell us what needs to be done. I am happy to read the documentation. That said, I have tried numerous times to sign the p2 artifacts without success (there are few PRs and milestone releases performed only for the signing) |
|
You can compare your feature.xml's project against this example: https://git.eclipse.org/c/emf/org.eclipse.emf.git/tree/features/org.eclipse.emf-feature You really should include description, copyright, and most especially the license elements. You do not need to include the *.html files in this folder: That's because the build process should copy over properties and license files from the license plugin from CBI. But the missing element in the feature.xml will result in the p2 content metadata not containing the license reference even if the actual jar does contain the copied-over license. Your two bundles are signed, but the two artifacts for the two features are not signed. In think you need to enable something like the for the feature artifacts to be properly signed: The tag is just so we could do builds without signing so you don't need that part, but you need to do something like this for the feature artifacts to be signed. |
|
Ok. I’ll give it a try later today. Thanks for your help! |
|
Sorry for not answering earlier, as I was busy with other tasks - if some help is necessary, I could try to have a look at the underlying issue next week. |
|
It would be ideal if this were done for contribution to 2019-12 M2: https://wiki.eclipse.org/Category:SimRel-2019-12#Schedule It's likely that contributions that do not conform to these minimal requirements will be disabled soon after that point. If you produce a new update p2 site and let me know the URL for it, I can have a quick look to see its state. |
|
I had a look at the issue: the latest release site was much better, as it had the required metadata included, including the EPLv2 license text, however, it was not signed. I have opened PR #770 that ensures that EPLv1 is loaded (as far as I could see, the project is licensed under EPLv1.0) and signs the service. A p2 repository with the signature and license entries is available for now at https://ci.eclipse.org/viatra/job/ec-feature-fix/lastSuccessfulBuild/artifact/p2-feature/org.eclipse.collections.repository/target/repository/ |
|
I downloaded the zipped update site and tested it locally and indeed the proper SUA 1.1 is used, all five artifacts are properly signed, and you have a *.pack.gz for the library jar (which is 15% of the size of the normal jar). That's perfect. Thanks for taking action. (I always enjoy reading the blogs about this stuff.) |
Fixes generated Eclipse features #763
|
@nikhilnanivadekar Is there any p2 repository available that contains the signed feature? I am asking before it should be added to the SimRel repository as soon as possible (I'd rather have a version included before M3 for the December release). Right now the repository contains version 9.2 (added by myself about a year ago); if you point me to an appropriate repository, I can update the contribution right now. |
|
The signed feature will go for 10.1.0 I think. But if we want to have the signed feature I can cherry pick your commits and do a bug fix release of 10.0.1. |
|
I don't know what was the planned release date for 10.1.0; for SimRel 2019-12 the release date should be not later than the 18th December (and the final build should be ready for the 11th, the final RC build date). To me the version number is not that important; maybe because of the short notice, a bugfix version (10.0.1) would be cleaner. However, whichever direction you want to go, it would be important to have a pre-release build with the final version number available for next weeks M3 milestone, as that would give others (including the VIATRA project I am responsible for) to test whether everything works as expected). |
|
Let me work on 10.1.0 Milestone today so that we can contribute that. I’ll schedule 10.1.0 to be released at the first available release for December |
|
Reopening for tracking work for 10.1.0 and simrel contribution. |
|
Created release: https://projects.eclipse.org/projects/technology.collections/releases/10.1.0 |
|
The CI Instance of Eclipse Collections is having issues connecting to GitHub to create the artifacts: Bugzilla raised: https://bugs.eclipse.org/bugs/show_bug.cgi?id=553330 |
|
@ujhelyiz the p2 artifacts for 10.1.0.M1 are pushed. Build: https://ci.eclipse.org/collections/job/publish-p2-repo/ |
|
I have looked at the build job, but I have a question: where can I find the built repository? I don't see any links, etc. Furthermore, looking into the build log the feature version 10.0.0-SNAPSHOT seems incorrect to me, considering we are aiming to have 10.1.0 milestone build here. It might be fine, but I don't know where to check. |
|
@ujhelyiz you are correct 10.0.0-SNAPSHOT seems incorrect. Where can I see the feature version is setup to debug? |
|
@ujhelyiz I fixed the build script. Now we have the artifacts published. Can you please take a look? |
|
Glad to hear the build works, sorry I was not able to help before. Yes, I see that the feature is versioned 10.0.0.v20191122-1234 (the end qualifier is fine). This version is set in the maven pom.xml instances related to the build and the feature.xml file. PR #472 seems to include such a version bump. However, executing the command |
|
@ujhelyiz I investigated further about the 10.0.0-SNAPSHOT issue. Seems like the features folder does not get updated during the build processes with the correct qualifiers: https://github.com/eclipse/eclipse-collections/tree/master/p2-feature Can you please tell me all the files where it needs to be updated. I will try to fix it in the build or if not fix it manually. I wish there was an automated way to do this. |
|
@ujhelyiz let me try to configure that command and rerun the snapshot build. |
|
@ujhelyiz I dont think that really worked. I am trying to set it on our Jenkins build. Any tips to do that vs the plain command line? Log: https://ci.eclipse.org/collections/job/new-version/44/consoleFull |
|
@ujhelyiz I have been trying to even make it work and run in my local, but without luck. If you are able to run the command and push a commit, raise a PR, I will happily merge the PR 😄 |
Signed-off-by: Zoltan Ujhelyi <zoltan.ujhelyi@incquerylabs.com>
Signed-off-by: Zoltan Ujhelyi <zoltan.ujhelyi@incquerylabs.com>
|
I have opened PR #776 with the fix. I have seen two issues while trying to do this:
The version bump was done programmatically: |
Signed-off-by: Zoltan Ujhelyi <zoltan.ujhelyi@incquerylabs.com>
|
@ujhelyiz thanks a ton for your help! I fixed it on the Jenkins build so that going forward we do not need to worry about it for every release. Screenshot of the configuration: I think you can drop the second commit, if you rebase on to upstream/master then I can merge your PR. |
Build fixes for release. Part of #763
|
@ujhelyiz 10.1.0.M2 is deployed to maven central and to Eclipse p2 repository. Can you please test it out and verify? Thank you very much for your help! |
|
Sadly, the p2 repository is not published; I have not seen it at downlooad.eclipse.org According to https://ci.eclipse.org/collections/job/publish-p2-repo/26/console the publishing failed.
|
|
I am checking what went wrong. I won’t deny that I am totally confused why build 25 worked and 26 didn’t even when there are no changes 🤷♂️ |
|
I have reverted the config from build 25. I do not remember changing the config for 26, but the config seemed to have been reverted to the one used by 24. Kicked off the build again, let us see. |
|
The repository https://download.eclipse.org/collections/10.1.0.M2/repository/ seems now correct. I have executed tests, and for now create a gerrit change for the simrel repository to add this change to the aggregation (will not merge it until you have reviewed it of course). This way it will be ready for this weeks milestone. |
|
The simrel Gerrit change is available from https://git.eclipse.org/r/c/153330/ - it seems the validation finished correctly, so it could be merged as well. |
|
@ujhelyiz I have approved the code review but I can only give a +1, I think we need a ++1 correct to be merged? Please let me know if anything else needs to be done. |
|
@nikhilnanivadekar Yes, it needs a +2 from someone with commit rights to the repository. If nobody from the project has commit rights, you should write a Bugzilla issue to Community/Cross-project category, and the webmaster team will set up the permissions. For now, I have added that and merged the code. This means, the next SimRel build will include this milestone build. After the final release build is ready, this contribution needs to be updated the same way. |
|
Perfect! Thank you very much! |
|
The latest repository report shows the Eclipse Collection issues fixed. |
|
Great! Thanks a ton! |
|
@ujhelyiz 10.1.0 is available in the p2 repo, can you please check? |
|
The build looks reasonable to me; I have also created a Gerrit change for SimRel: https://git.eclipse.org/r/c/153909/ |
|
Perfect! Thanks @ujhelyiz |
Looking at this report, specifically for Eclipse Collections contribution to SimRel:
https://download.eclipse.org/oomph/archive/simrel/collections.aggrcon/index.html
It's clear that you folks need to add a proper license to the feature and that you need to sign the feature's jars.
I've tried to get your attention via this channel:
https://www.eclipse.org/lists/cross-project-issues-dev/msg17024.html
But the latest contributions are still in bad shape.
At some point I'll ask that the planning council remove such non-conforming contributions...
If there's something I can do to help, feel free to ask.
The text was updated successfully, but these errors were encountered: