Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven pluginRepository: use 'https' instead of 'http' #750

Merged

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Sep 10, 2019

No description provided.

@nikhilnanivadekar
Copy link
Contributor

@sullis I am fine with this change. However, your ECA is not passing. Can you please follow the instructions here and get it signed and also sign-off your commit:
https://github.com/eclipse/eclipse-collections/blob/master/CONTRIBUTING.md#contributor-license

@nikhilnanivadekar
Copy link
Contributor

@sullis any updates on this?

@sullis sullis force-pushed the maven-pluginRepository-https branch from e444fc4 to 9755167 Compare October 28, 2019 16:18
@nikhilnanivadekar
Copy link
Contributor

Can you please rebase on to master? I will merge it after it is rebased. Please comment back on this PR and tag me so that I can merge it immediately! Thank you for your contribution.

Signed-off-by: Sean C. Sullivan <github@seansullivan.com>
@sullis sullis force-pushed the maven-pluginRepository-https branch from 9755167 to 3348183 Compare December 29, 2019 22:39
@sullis
Copy link
Contributor Author

sullis commented Dec 29, 2019

ping @nikhilnanivadekar

@nikhilnanivadekar
Copy link
Contributor

Thank you @sullis

@nikhilnanivadekar nikhilnanivadekar merged commit 89fa2d2 into eclipse:master Dec 29, 2019
@sullis sullis deleted the maven-pluginRepository-https branch December 29, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants