Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for textDocument/foldingRange #694

Closed
fbricon opened this issue Jun 12, 2018 · 4 comments
Closed

Add support for textDocument/foldingRange #694

fbricon opened this issue Jun 12, 2018 · 4 comments

Comments

@fbricon
Copy link
Contributor

fbricon commented Jun 12, 2018

Add support for textDocument/foldingRange, which allows editors to provide folding support (for code blocks, imports, folding regions ...). See LSP proposal: https://github.com/Microsoft/vscode-languageserver-protocol-foldingprovider/blob/master/protocol.foldingProvider.md

@fbricon
Copy link
Contributor Author

fbricon commented Jun 12, 2018

Requires upstream lsp4j implementation: eclipse-lsp4j/lsp4j#169

@fbricon fbricon added this to the End March 2019 milestone Mar 20, 2019
@fbricon
Copy link
Contributor Author

fbricon commented Mar 20, 2019

I missed the missing region delimiters folding support, before merging #962.
@yaohaizh can you please add support for:

  • //#region and //#endregion
  • //region and //endregion
  • Netbeans format : // <editor-fold desc="Description"> and // </editor-fold>

@yaohaizh
Copy link
Contributor

Interesting. Should we support the //#region and //#endregion? It is a C# grammar.

@fbricon
Copy link
Contributor Author

fbricon commented Mar 21, 2019

yup, just so that we keep feature parity with the current vscode-java implem

@fbricon fbricon closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants