Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Maven offline mode (java.import.maven.offline.enabled) #2187

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Add support for Maven offline mode (java.import.maven.offline.enabled) #2187

merged 1 commit into from
Aug 9, 2022

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Aug 9, 2022 •
edited
Loading

Fixes #2186
Requires redhat-developer/vscode-java#2617

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

@snjeza snjeza mentioned this pull request Aug 9, 2022
Merged
@rgrunber
Copy link
Contributor

rgrunber commented Aug 9, 2022

Also looks like M2E 2.0.1 is out since a few days ago. @snjeza if we can easily update, it might be worth it.

@snjeza snjeza force-pushed the issue-2186 branch 2 times, most recently from aa5eb45 to f7f084e Compare August 9, 2022 21:20
@snjeza
Copy link
Contributor Author

snjeza commented Aug 9, 2022

Also looks like M2E 2.0.1 is out since a few days ago. @snjeza if we can easily update, it might be worth it.

@rgrunber I have updated the m2e target platform.

@snjeza
Add the java.import.maven.offline.enabled property
fc78e50 
Update m2e to 2.0.1

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@snjeza snjeza changed the title Add the java.import.maven.offline property Add the java.import.maven.offline property.enabled Aug 9, 2022
@snjeza snjeza removed the in progress label Aug 9, 2022
@rgrunber rgrunber changed the title Add the java.import.maven.offline property.enabled Add the java.import.maven.offline.enabled property Aug 9, 2022
rgrunber
rgrunber approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works fine for me.

@rgrunber rgrunber added this to the End August 2022 milestone Aug 9, 2022
@rgrunber rgrunber changed the title Add the java.import.maven.offline.enabled property Add support for Maven offline mode (java.import.maven.offline.enabled) Aug 9, 2022
@snjeza
Copy link
Contributor Author

snjeza commented Aug 9, 2022

test this please

1 similar comment
@snjeza
Copy link
Contributor Author

snjeza commented Aug 9, 2022

test this please

@snjeza snjeza merged commit 4818c60 into eclipse-jdtls:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@gorkem gorkem Awaiting requested review from gorkem

@fbricon fbricon Awaiting requested review from fbricon

@jdneo jdneo Awaiting requested review from jdneo

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
enhancement maven
Projects
None yet
Milestone
End August 2022
Development

Successfully merging this pull request may close these issues.

Add the java.import.maven.offline property
2 participants
@snjeza @rgrunber