Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean up to invert equals calls on null #2342

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

JessicaJHee
Copy link
Contributor

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I think it just needs a test

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, so I think we can merge once ready.

Signed-off-by: Jessica He <jhe@redhat.com>
@rgrunber rgrunber added this to the End November milestone Nov 24, 2022
@rgrunber rgrunber merged commit 5cd3727 into eclipse-jdtls:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants