Add extendedClientCapability to skip propagation of TextEdits #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2023
|
If this sounds better, we can imagine instead of a boolean some property called |
mickaelistria
force-pushed
the
text-edits
branch
from
db850c7
to
bd15b2e
Compare
mickaelistria
force-pushed
the
text-edits
branch
from
bd15b2e
to
6dfbfa8
Compare
|
Change looks fine to me. I would just be careful in the future for clients implementing things like paste event handlers, since those are instances where user inputs text, where the LS might produce a completely different text edit than the client (and the client should defer to LS). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.