Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Join and Split variable quick actions. #2732

Merged
merged 1 commit into from Jul 4, 2023

Conversation

gayanper
Copy link
Contributor

Add support for Split and Join variable quick actions with Unit Tests.

@gayanper
Copy link
Contributor Author

@rgrunber The new PR for split and join variable actions

@rgrunber
Copy link
Contributor

rgrunber commented Jun 27, 2023

I'm going to update the TP in #2731 but it may not be enough. Unfortunately we have a test regression that prevented me from using the I20230626. See eclipse-jdt/eclipse.jdt.core#1103 (comment) .

Update: I've updated to I20230629-1800 which should contain the needed API and fix the regression.

Copy link
Contributor

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works well around comments and lambda expressions declarations too.

@rgrunber rgrunber added this to the End July 2023 milestone Jul 4, 2023
@rgrunber rgrunber merged commit feff0c4 into eclipse-jdtls:master Jul 4, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants