Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectpacking does microlayout only after the layout step #996

Closed
soerendomroes opened this issue Feb 12, 2024 · 2 comments · Fixed by #997
Closed

Rectpacking does microlayout only after the layout step #996

soerendomroes opened this issue Feb 12, 2024 · 2 comments · Fixed by #997
Labels
alg-rectpacking Affects the ELK RectPacking algorithm.
Milestone
Release 0.9.1

Comments

@soerendomroes
Copy link
Contributor

See here.

Since the micro layout executes after the layout step, the node size is only determined after everything is already placed (which is bad). We should consider doing it before the layout step.
@soerendomroes soerendomroes added the alg-rectpacking Affects the ELK RectPacking algorithm. label Feb 12, 2024
@soerendomroes soerendomroes added this to the Release 0.9.1 milestone Feb 12, 2024
@soerendomroes
Copy link
Contributor Author

Something tells me that I had good reasons to put this at the end. Please investigate.

@soerendomroes
Copy link
Contributor Author

The whitespace elimination wants it at the end. Maybe just do it at the beginning (for this bug) and at the end (for whitespace elimination?

@soerendomroes soerendomroes mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
alg-rectpacking Affects the ELK RectPacking algorithm.
Projects
None yet
Milestone
Release 0.9.1
1 participant
@soerendomroes