Improve default Engine addon launch conf tab #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the class LaunchConfigurationTab was duplicated in 3 launchers. now moved into the framework and renamed AbstractLaunchConfigurationTab Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
the class LaunchConfigurationDataProcessingTab was duplicated in 2 launchers. now moved into the framework and renamed AbstractLaunchConfigurationDataProcessingTab Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
getExtensionSpecifications is used uniformly to filter addon extensions in launcher Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Conflicts: plugins/org.eclipse.gemoc.ale.interpreted.engine.ui/src/org/eclipse/gemoc/ale/interpreted/engine/ui/launcher/tabs/LaunchConfigurationMainTab.java Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR of eclipse/gemoc-studio-modeldebugging#136
It adapts the addon definition to use lowercase in the plugin.xml
It makes sure to use the new
AbstractLaunchConfigurationDataProcessingTabclass