Add information about number of completed steps in the EngineStatus class #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as opposed to nbLogicalStepRun tha count only finished steps, this information counts the calls. This contributes to eclipse/gemoc-studio#123 by offering a way to control if the debug commands have been taken into account Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
the data about called step vs run step is used to display information about number of completed/not completed steps in the Engine view Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
dvojtise
added a commit
that referenced
this pull request
Jan 15, 2020
* put section Simulation model animation framework before GEMOC Framework * add images from simulationmodelanimation dev * fix path to images * Add an helper method that computes an uri based printable name ** this helper method computes a printable name for a model element based on the uri in its resource. usefull in complement of xtext DefaultDeclarativeQualifiedNameProvider (not part of this plugin due to the dependency to xtext) * use smarter name for the resource ** make sure to use a unique name relatively to the resource set, if last segment not unique, use full uri * added @step on main methods of official examples ** this makes the stack looks better * fix tests for new UI Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new data in
org.eclipse.gemoc.xdsmlframework.api.core.engineStatusIn addition of nbLogicalStepRun that returns the number of completed steps there is now also the number of called step.
This information is used to display a better Engine View by also showing the "Not Completed" steps
It is also used in by test suites in order to manage the execution (and reduce flaky tests eclipse/gemoc-studio#123 )
In the following capture, the number between square brackets indicates the number of not completed steps (which in this case is the same as the depth of the stack)
