Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable multidimensionnal trace saving #206

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Conversation

dvojtise
Copy link
Contributor

Description

Reenable saving of multidimentional trace (as seen in #204)

It adds new options on the addon to let the user the choice to enable or disable this saving either on every steps, on engine stop or none of them.

It fixes the setup of the initial value of the launch configuration wizard when an addon option default value is "true". (this default value was ignored by the launch configuration page)

Contribution to issues

Closes #204
Closes #205

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
add user configurable addon option to save trace on step
add user configurable addon option to save trace on engine stop

fix #204
fix #205

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
@dvojtise dvojtise requested a review from ebousse October 20, 2021 15:42
Copy link
Contributor

@ebousse ebousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried with the CI build real quick, and worked as expected.

@ebousse ebousse merged commit 59cb510 into master Oct 21, 2021
@dvojtise dvojtise deleted the reenable_trace_saving branch January 7, 2022 16:29
@dvojtise dvojtise added the bug label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants