Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gemoc project template wizard #5

Merged
merged 10 commits into from
Sep 27, 2017
Merged

Improve gemoc project template wizard #5

merged 10 commits into from
Sep 27, 2017

Conversation

dvojtise
Copy link
Contributor

This PR add several improvment in the templates of the GEMOC project wizard.

  • improved messages (added a (*) to indicate mandatory fields
  • added new template for melange with 2 languages (with inheritance)

This PR can be tested using the result of the following CI job
https://ci.eclipse.org/gemoc/job/gemoc-studio/job/improve-gemoc-project-template-wizard/

This PR relies on the PR#9 on gemoc-studio: eclipse/gemoc-studio#9

@dvojtise
fix id for projectContent and template extension points
4352dee 
ie. org.eclipse.gemoc.commons.eclipse.pde.projectContent and
org.eclipse.gemoc.commons.eclipse.pde.template

Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
improve wizard for a single melange language
6034dea 
Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
remove dead code
4325ab5 
Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
harmonize class name
46de959 
Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
code cleanup
bce5a1b 
Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
code cleanup
5fbfc0e 
Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
added new template to create a melange with 2 languages
4bd0860 
One external language + another that inherits from it

Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@fcoulon
Copy link
Contributor

fcoulon commented Sep 19, 2017

Seems there is no .melange when creating a new sequential project

@dvojtise
Copy link
Contributor Author

which of the 2 templates did you use ?

@fcoulon
Copy link
Contributor

fcoulon commented Sep 19, 2017

I tried with the Studio from the link above.
I only have Simple Gemoc Sequential project in the template page

@dvojtise
Copy link
Contributor Author

Mhh, I may have forgot to commit something or need to force a build on the CI

@dvojtise
improved templates
49c835c 
- better default values in case of empty ecore
- improved comments in the generated files

Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
Copy link
Contributor Author

I've forced a build on the CI

in addition I've improved the templates

  • better default values in case of empty ecore
  • improved comments in the generated files (ie. tries to teach the user how to use the languages for typical situations)

@fcoulon
Copy link
Contributor

fcoulon commented Sep 20, 2017

Works for me

@ebousse
Copy link
Contributor

ebousse commented Sep 26, 2017

Just tested quickly, and I tried with a language name aaa, which creates a Melange error because the language name should start with an upper case. Maybe this check could be added in the wizard? Maybe the Melange validator code can be reused for the fields of the wizard?

Other than that, seems to work well!

Other than that, after this PR is merged, I would advise opening an issue on the clarity of the names given to the wizards (as we discussed IRL). The two choices are only made different using the word "Simple", which is clearly not enough. The descriptions of the choices are not enough either.

@dvojtise
improved description of the template wizard
a559fad 
Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise
added a check on language names
9e05817 
an error will be displayed if the name doesn't start by an uppercase
letter

Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
@dvojtise dvojtise merged commit 8ab4ae7 into master Sep 27, 2017
@dvojtise dvojtise deleted the improve-gemoc-project-template-wizard branch October 12, 2017 16:03
dvojtise added a commit to eclipse/gemoc-studio-execution-java that referenced this pull request Jan 14, 2020
@dvojtise
Improve gemoc project template wizard (eclipse/gemoc-studio-modeldebu…
7a3b03b 
…gging#5)

* fix id for projectContent and template extension points

ie. org.eclipse.gemoc.commons.eclipse.pde.projectContent and
org.eclipse.gemoc.commons.eclipse.pde.template
* improve wizard for a single melange language

* remove dead code

* harmonize class name

* code cleanup
* added new template to create a melange with 2 languages

One external language + another that inherits from it

* improved templates

- better default values in case of empty ecore
- improved comments in the generated files

* improved description of the template wizard
* added a check on language names 


an error will be displayed if the name doesn't start by an uppercase
letter

Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebousse ebousse Awaiting requested review from ebousse

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvojtise @fcoulon @ebousse