Move dsl default location to project root and minor Melange related refactoring #76
Conversation
move location where the dsl file is created when using new sequential project wizard contribute to #65 Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
do not use melange wizard as base for creating non melange projects Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
otherwise the scan of branch does not detect the change and does not create a job if there is not branch on the main repo the jenkins files must be identical Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
this contain additional support for #65 Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
|
Just curious: why does the PR have so many added lines (+669) for very few removed lines (−43)? Shouldn't it simply change existing code to adapt to the new path? |
|
True, I forgot to mention 2 additional stuff I did commit when writing this PR:
|
|
Ah I see, I understand better then. Maybe then you should change the PR title, to have a cleaner squash and changelog afterwards? |
dvojtise
changed the title
dvojtise
changed the title
|
Also two tests appear to fail: https://ci.eclipse.org/gemoc/job/gemoc-studio/job/move_dsl_default_location_to_project_root/ With the same error: Some problems in the Melange generated code. Could it be caused to your Melange-related changes? This would be strange since this seems to be caused by core Melange services. |
|
Yes, I'm on it. I did not intend to accept a PR with failed tests 😉 (this is just a pain to have to switch between 2 branches when working on 2 PRs and try to validate them locally) I'll try to get the Eclipse package and regenerate everything for the example and not just the runtime |
|
OK great :) good luck with bug hunting! |
may have an impact on eclipse/gemoc-studio#123 Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
|
tests are now successful and ready for review, squash and merge 😄 |
…efactoring (eclipse/gemoc-studio-modeldebugging#76) * change location of dsl file for new sequential project move location where the dsl file is created when using new sequential project wizard contribute to eclipse/gemoc-studio-modeldebugging#65 * some melange cleanup: do not use melange wizard as base for creating non melange projects. introduced a class AbstractNewProjectWizardWithTemplates that implements INewWizard in order to replace the use of NewMelangeProjectWizard * reintroduce a jenkins file otherwise the scan of branch does not detect the change and does not create a job if there is not branch on the main repo. The jenkins files must be identical on all repos. * bump melange to 2018-11-29 this contain additional support for eclipse/gemoc-studio-modeldebugging#65 * make sure preferences settings declares java 1.8 ->may have an impact on eclipse/gemoc-studio#123 Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
This PR changes the default location for .dsl files.
The wizards and Melange will now place them at the root of the project.
This contributes to fix #65
This PR also does some minor code cleanup by removing unnecessary dependencies to Melange
This PR comes with PR eclipse/gemoc-studio#124