Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegacyFSM example should be renamed #84

Closed
dvojtise opened this issue Jun 8, 2018 · 4 comments
Closed

LegacyFSM example should be renamed #84

dvojtise opened this issue Jun 8, 2018 · 4 comments
Assignees

Comments

@dvojtise
Copy link
Contributor

dvojtise commented Jun 8, 2018

Now that we have other technology specific examples, (such as K3FSM) we now should rename the LegacyFSM in something clearer.

If the example mimics code reuse of a "legacy" language as a general concerns, this name doesn't help to understand implied technologies and how the languages are built.

This is actually an example of use of GEMOC with Melange+K3 in order create 2 languages that inherits one from another (thus enabling model conversion, editor code reuse, etc)

my suggestion: MelangeK3FSM

other suggestions are welcome for a better name... 😉

@dvojtise
Copy link
Contributor Author

dvojtise commented Jul 19, 2018

any opposition for this name: MelangeK3FSM ?

(I don't want to start the renaming without consent, since the example is also used in the test, it'll be a tedious work)

@ebousse
Copy link
Contributor

ebousse commented Nov 13, 2018

MelangeK3FSM is good for me, it would me much clearer than the current names available in the examples menu :)

@dvojtise
Copy link
Contributor Author

dvojtise commented Dec 5, 2018

I also plan to change the "sample" part to "example" which is probably a better English term

@dvojtise
Copy link
Contributor Author

dvojtise commented Feb 4, 2019

done and distributed with PR #136

@dvojtise dvojtise closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants