Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Starting a Gradle 6 Kotkin build script #545

Merged
merged 16 commits into from Sep 4, 2020
Merged

Starting a Gradle 6 Kotkin build script #545

merged 16 commits into from Sep 4, 2020

Conversation

jponge
Copy link
Contributor

@jponge jponge commented Aug 25, 2020

No description provided.

@jponge jponge added this to the 3.4.0 milestone Aug 25, 2020
@jponge jponge added this to In progress in 3.4.0 release via automation Aug 25, 2020
@jponge
Copy link
Contributor Author

jponge commented Aug 25, 2020

@yloiseau I started this, it's not finished yet (docs, publishing) but it should already make tests pass.

@jponge
Copy link
Contributor Author

jponge commented Aug 27, 2020

@yloiseau I think right now the proposed build is more or less equivalent to the previous one, except that it's Gradle 6 and Kotlin script is a joy compared to Groovy. Feel free to test and let me know or directly push to this draft pr branch. There are still a few things to polish like building the Maven plugin.

I have configured the publication to Sonatype OSS, which we didn't have before. With my credentials set up I've been able to deploy a few 3.4.0-SNAPSHOT to https://oss.sonatype.org

This makes me think that:

  1. there is no good incentive to go through Bintray as a gateway anymore, with OSS Sonatype credentials and a GnuPG key we can just publish directly releases and snapshots,
  2. we used to publish binary builds (.zip / .tar.gz) on Bintray, but we could just upload to GitHub releases. It's only 2 files to upload.

WDYT?

/cc @k33g

@jponge
Copy link
Contributor Author

jponge commented Aug 27, 2020

Another side note: we could ditch Travis-CI and go with GitHub Actions for regular CI and deploying snapshots.

@jponge jponge mentioned this pull request Aug 28, 2020
@jponge
Copy link
Contributor Author

jponge commented Aug 28, 2020

@yloiseau @k33g in terms of build functionality, do you see anything missing right now? There's still the old.build.gradle for reference in this draft.

@yloiseau
Copy link
Contributor

yloiseau commented Sep 1, 2020

$ ./gradlew publishToMavenLocal

Execution failed for task ':signMainPublication'.
> Cannot perform signing task ':signMainPublication' because it has no configured signatory

which used to work

@yloiseau
Copy link
Contributor

yloiseau commented Sep 1, 2020

The javadoc used to have a customized header for style sheet and highlighting JS

@jponge
Copy link
Contributor Author

jponge commented Sep 1, 2020

@yloiseau yes I haven't been able to port that

@jponge
Copy link
Contributor Author

jponge commented Sep 1, 2020

$ ./gradlew publishToMavenLocal

Execution failed for task ':signMainPublication'.
> Cannot perform signing task ':signMainPublication' because it has no configured signatory

which used to work

That requires GPG/Gradle configuration on your side

@yloiseau
Copy link
Contributor

yloiseau commented Sep 1, 2020

$ ./gradlew publishToMavenLocal

Execution failed for task ':signMainPublication'.
> Cannot perform signing task ':signMainPublication' because it has no configured signatory

which used to work

That requires GPG/Gradle configuration on your side

Even for local repository ? It used to work (for local tests)

@jponge
Copy link
Contributor Author

jponge commented Sep 1, 2020

@jponge jponge linked an issue Sep 3, 2020 that may be closed by this pull request
@yloiseau yloiseau self-requested a review September 4, 2020 11:30
3.4.0 release automation moved this from In progress to Reviewer approved Sep 4, 2020
@jponge
Copy link
Contributor Author

jponge commented Sep 4, 2020

Still have to remove the old Gradle build file :-)

@jponge jponge marked this pull request as ready for review September 4, 2020 13:51
@jponge jponge merged commit 1feeb6b into master Sep 4, 2020
3.4.0 release automation moved this from Reviewer approved to Done Sep 4, 2020
@yloiseau yloiseau deleted the gradle6 branch December 1, 2020 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
3.4.0 release
  
Done
Development

Successfully merging this pull request may close these issues.

Upgrade to Gradle 6
2 participants