Fix combobox initial selection #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix the combobox initial selection rendering issue Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
…nder convertor, adapted code Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
…pted usage Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
… initial combobox selection, adapted corresponding usages Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
…he initial selection of Ds type, adapted code Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
a-sayyed
approved these changes
Sep 22, 2020
| /** | ||
| * Element provides a distribution set id | ||
| * Element provides a distribution set info | ||
| */ | ||
| public interface DsIdAware { |
There was a problem hiding this comment.
minor: should we then rename the class to something like DsInfoAware?
krishna-devolo
pushed a commit
to devolo/hawkbit
that referenced
this pull request
Sep 23, 2021
* extended TargetFilterQueryAware interface with target filter name to fix the combobox initial selection rendering issue Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io> * introduced ProxyTargetFilterQueryInfo for consistency and usage of binder convertor, adapted code Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io> * removed ProxyIdNameVersion in favour of ProxyDistributionSetInfo, adapted usage Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io> * changed DsIdAware to use ProxyDistributionSetInfo in order to fix the initial combobox selection, adapted corresponding usages Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io> * changed ProxySystemConfigWindow to use the ProxyTypeInfo for fixing the initial selection of Ds type, adapted code Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011