New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index on "last_modified_at" column in "sp_target" table #1015
Conversation
7678290
to
395c8a3
Compare
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
395c8a3
to
bfbe995
Compare
...hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaTarget.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sergey, thanks for this contribution!
Please see my one comment below.
Thanks and regards
Stefan
...sitory-jpa/src/main/resources/db/migration/DB2/V1_12_17__add_index_target_modified___DB2.sql
Outdated
Show resolved
Hide resolved
...pository-jpa/src/main/resources/db/migration/H2/V1_12_17__add_index_target_modified___H2.sql
Outdated
Show resolved
Hide resolved
...ry-jpa/src/main/resources/db/migration/MYSQL/V1_12_17__add_index_target_modified___MYSQL.sql
Outdated
Show resolved
Hide resolved
.../main/resources/db/migration/POSTGRESQL/V1_12_17__add_index_target_modified___POSTGRESQL.sql
Outdated
Show resolved
Hide resolved
.../main/resources/db/migration/SQL_SERVER/V1_12_17__add_index_target_modified___SQL_SERVER.sql
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
Thanks for your feedback, Stefan! I've added 'tenant' to the index as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
…pse#1015) * Create index on "last_modified_at" column in "sp_target" table. * Added tenant to the index. Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
Indexing the column
last_modified_at
insp_target
table should improve database performance, since the default ordering behaviour in the "Deployment View" isORDER BY "last_modified_at"