Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index on "last_modified_at" column in "sp_target" table #1015

Merged
merged 2 commits into from Oct 13, 2020

Conversation

Sergey-G-dev
Copy link
Contributor

Indexing the column last_modified_at in sp_target table should improve database performance, since the default ordering behaviour in the "Deployment View" is ORDER BY "last_modified_at"

Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
Copy link
Contributor

@stefbehl stefbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sergey, thanks for this contribution!
Please see my one comment below.

Thanks and regards
Stefan

@eclipse eclipse deleted a comment from hawkbit-bot Oct 13, 2020
@schabdo schabdo added this to the 0.3.0M7 milestone Oct 13, 2020
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
@Sergey-G-dev
Copy link
Contributor Author

Thanks for your feedback, Stefan! I've added 'tenant' to the index as requested.

Copy link
Contributor

@stefbehl stefbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@stefbehl stefbehl merged commit 99c8725 into eclipse:master Oct 13, 2020
@Sergey-G-dev Sergey-G-dev deleted the db-migration branch October 13, 2020 16:00
@schabdo schabdo changed the title Create index on "last_modified_at" column in "sp_target" table. Index on "last_modified_at" column in "sp_target" table Feb 12, 2021
krishna-devolo pushed a commit to devolo/hawkbit that referenced this pull request Sep 23, 2021
…pse#1015)

* Create index on "last_modified_at" column in "sp_target" table.
* Added tenant to the index.

Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexing the column 'last_modified_at' in 'sp_target' table.
3 participants