Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not accept valid token headers by default #1074

Merged
merged 1 commit into from Jan 22, 2021

Conversation

schabdo
Copy link
Member

@schabdo schabdo commented Jan 22, 2021

The default DDI configuration excepted valid target and gateway token headers even the option to allow them was not set explicitly within settings menu of the management UI. Documentation clearly state that both need to be enabled first

Fixes #1066

Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
@schabdo schabdo added the bug label Jan 22, 2021
@schabdo schabdo added this to the 0.3.0M7 milestone Jan 22, 2021
@schabdo schabdo requested a review from stefbehl January 22, 2021 13:14
Copy link
Contributor

@stefbehl stefbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Dominic.

@stefbehl stefbehl merged commit 632bd26 into eclipse:master Jan 22, 2021
@stefbehl stefbehl deleted the fix-default-config branch January 22, 2021 13:54
Bastian-Krause added a commit to Bastian-Krause/rauc-hawkbit-updater that referenced this pull request Feb 17, 2021
… via MGMT API

hawkBit's default of "authentication.targettoken.enabled" changed from
true to false:

  eclipse/hawkbit#1074

Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause added a commit to Bastian-Krause/rauc-hawkbit-updater that referenced this pull request Feb 17, 2021
… via MGMT API

hawkBit's default of "authentication.targettoken.enabled" changed from
true to false:

  eclipse/hawkbit#1074

Enable the config option explicitly to make our tests work again.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecurityToken Auth works per default without enabeling it in de Management UI
2 participants