Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement within SecurityManagedConfiguration #821

Merged
merged 1 commit into from Apr 17, 2019

Conversation

schabdo
Copy link
Member

@schabdo schabdo commented Apr 9, 2019

Fixed a bunch of generics and removed duplicate registration of VaadinRedirectStrategy bean

@@ -545,6 +544,15 @@ public void destroy() {
@Autowired
private HawkbitSecurityProperties hawkbitSecurityProperties;

private final VaadinUrlAuthenticationSuccessHandler handler;

public UISecurityConfigurationAdapter(final VaadinRedirectStrategy redirectStrategy) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Document this public constructor. rule

@hawkbit-bot
Copy link

SonarQube analysis reported 1 issue

  • MINOR 1 minor

Watch the comments in this conversation to review them.

Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
@schabdo schabdo added this to the 0.3.0M3 milestone Apr 9, 2019
@schabdo schabdo merged commit 44e753a into eclipse:master Apr 17, 2019
@schabdo schabdo deleted the fix-bean-handling branch April 17, 2019 08:56
AmmarBikic pushed a commit to bosch-io/hawkbit that referenced this pull request Oct 2, 2020
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants