Fix for endless loop when an exception of type EntityAlreadyExistsException is thrown in the context of the retryable findOrRegisterTargetIfItDoesNotExist method
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
hawkbit-bot
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
a-sayyed
commented
Apr 29, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
schabdo
suggested changes
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
Use thenThrow(Exception.class) instead of (new Exception()) Co-Authored-By: a-sayyed <ahmed.sayed@bosch-si.com>
schabdo
reviewed
Apr 29, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
use final modifier Co-Authored-By: a-sayyed <ahmed.sayed@bosch-si.com>
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
schabdo
reviewed
Apr 29, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
schabdo
approved these changes
Apr 29, 2019
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
schabdo
deleted the
fix_handle_EntityAlreadyExistsException_in_scheduled_tasks
branch
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
…eption is thrown in the context of the retryable `findOrRegisterTargetIfItDoesNotExist` method (eclipse#828) * fixed typo in method name Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com> * Added recover method to handle EntityAlreadyExistsException Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com> * Added tests Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com> * Apply suggestions from code review Use thenThrow(Exception.class) instead of (new Exception()) Co-Authored-By: a-sayyed <ahmed.sayed@bosch-si.com> * Apply suggestions from code review use final modifier Co-Authored-By: a-sayyed <ahmed.sayed@bosch-si.com> * Adapted review findings Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com> * Adapted review findings Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com> * added logs for EntityAlreadyExistsException case Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.