-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase target name to 128 and target controller id to 256 #849
Merged
stefbehl
merged 8 commits into
eclipse:master
from
bosch-io:feature/IncreaseTargetControllerIdAndTargetNameLimit
Jun 18, 2019
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5472223
Increase target name to 128 and target controller id to 256
floruschbaschan 58ef4cc
Fix test failures by using constant NamedEntity.NAME_MAX_SIZE + 1
floruschbaschan 4d9bd78
Use constant NamedEntity.NAME_MAX_SIZE + 1 for mgmt-resource tests
floruschbaschan 853c119
Add db migration scripts to increase the controllerId and name limit
floruschbaschan 1fde5a0
Fix review issues
floruschbaschan 4700f5b
Update assertion description
floruschbaschan 07a8c4c
Revert copyright years to its creator year
floruschbaschan 70b5ad4
Add DDI-, AMQP- and controller management-tests
floruschbaschan File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...in/resources/db/migration/DB2/V1_12_12__change_length_of_controller_id_and_name___DB2.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| ALTER TABLE sp_distribution_set ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_distribution_set_type ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_distributionset_tag ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_base_software_module ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_rollout ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_rolloutgroup ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_software_module_type ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_target ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_target_filter_query ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
| ALTER TABLE sp_target_tag ALTER COLUMN name SET DATA TYPE VARCHAR(128); | ||
|
|
||
|
|
||
| ALTER TABLE sp_target ALTER COLUMN controller_id SET DATA TYPE VARCHAR(256); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...main/resources/db/migration/H2/V1_12_12__change_length_of_controller_id_and_name___H2.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| ALTER TABLE sp_distribution_set ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_distribution_set_type ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_distributionset_tag ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_base_software_module ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_rollout ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_rolloutgroup ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_software_module_type ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_target ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_target_filter_query ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_target_tag ALTER COLUMN name VARCHAR(128); | ||
|
|
||
|
|
||
| ALTER TABLE sp_target ALTER COLUMN controller_id VARCHAR(256); |
13 changes: 13 additions & 0 deletions
13
...esources/db/migration/MYSQL/V1_12_12__change_length_of_controller_id_and_name___MYSQL.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| ALTER TABLE sp_distribution_set MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_distribution_set_type MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_distributionset_tag MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_base_software_module MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_rollout MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_rolloutgroup MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_software_module_type MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_target MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_target_filter_query MODIFY name VARCHAR(128); | ||
| ALTER TABLE sp_target_tag MODIFY name VARCHAR(128); | ||
|
|
||
|
|
||
| ALTER TABLE sp_target MODIFY controller_id VARCHAR(256); |
13 changes: 13 additions & 0 deletions
13
...b/migration/SQL_SERVER/V1_12_12__change_length_of_controller_id_and_name___SQL_SERVER.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| ALTER TABLE sp_distribution_set ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_distribution_set_type ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_distributionset_tag ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_base_software_module ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_rollout ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_rolloutgroup ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_software_module_type ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_target ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_target_filter_query ALTER COLUMN name VARCHAR(128); | ||
| ALTER TABLE sp_target_tag ALTER COLUMN name VARCHAR(128); | ||
|
|
||
|
|
||
| ALTER TABLE sp_target ALTER COLUMN controller_id VARCHAR(256); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please fix the assertion error message,
entity with too long version should not be createdinstead ofentity with too long name should not be created. It's in multiple places in this file