Ignore unknown properties on deserialisation of DDI-API model classes #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
laverman
requested changes
Aug 9, 2019
.../hawkbit-ddi-api/src/test/java/org/eclipse/hawkbit/ddi/json/model/DdiActionFeedbackTest.java
Show resolved
Hide resolved
...t/hawkbit-ddi-api/src/test/java/org/eclipse/hawkbit/ddi/json/model/DdiActionHistoryTest.java
Show resolved
Hide resolved
...st/hawkbit-ddi-api/src/test/java/org/eclipse/hawkbit/ddi/json/model/DdiArtifactHashTest.java
Show resolved
Hide resolved
...t-rest/hawkbit-ddi-api/src/test/java/org/eclipse/hawkbit/ddi/json/model/DdiArtifactTest.java
Show resolved
Hide resolved
Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
hawkbit-bot
reviewed
Aug 22, 2019
| @@ -25,7 +28,8 @@ | |||
| @NotNull | |||
| private final String value; | |||
|
|
|||
| public DdiMetadata(final String key, final String value) { | |||
| @JsonCreator | |||
| public DdiMetadata(@JsonProperty("key") final String key, @JsonProperty("value")final String value) { | |||
There was a problem hiding this comment.
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
schabdo
reviewed
Aug 22, 2019
...api/src/test/java/org/eclipse/hawkbit/ddi/json/model/JsonIgnorePropertiesAnnotationTest.java
Show resolved
Hide resolved
schabdo
reviewed
Aug 22, 2019
...bit-rest/hawkbit-ddi-api/src/test/java/org/eclipse/hawkbit/ddi/json/model/DdiStatusTest.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Aug 22, 2019
.../hawkbit-ddi-api/src/test/java/org/eclipse/hawkbit/ddi/json/model/DdiActionFeedbackTest.java
Outdated
Show resolved
Hide resolved
singrob
force-pushed
the
feature-improve_robustness_of_api_models
branch
from
3bfdb4a
to
170d21e
Compare
Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
singrob
force-pushed
the
feature-improve_robustness_of_api_models
branch
from
170d21e
to
9e430fa
Compare
Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
laverman
approved these changes
Aug 23, 2019
stefbehl
approved these changes
Aug 27, 2019
schabdo
changed the title
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
…es (eclipse#881) * added missing JsonIgnoreProperties annotation for DDI model classes * added Copyright Headers & serialization tests for all Ddi model classes * fixed typo in test * fixed review findings * added missing test descriptions Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JsonIgnoreProperties annotation to DDI Api model classes to ignore unknown properties on deserialisation
Signed-off-by: Robert Sing Robert.Sing@bosch-si.com