Add optional name to payload of thing created message #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
…CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
…_ATTRIBUTES Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
…RIBUTES Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
…ATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
|
Thanks for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution. |
AmmarBikic
force-pushed
the
feature_add_optional_name_to_thing_created
branch
3 times, most recently
from
52e35af
to
158f442
Compare
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
AmmarBikic
commented
Sep 19, 2019
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...f/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...dmf/hawkbit-dmf-api/src/main/java/org/eclipse/hawkbit/dmf/json/model/DmfAttributeUpdate.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...mf/hawkbit-dmf-api/src/main/java/org/eclipse/hawkbit/dmf/json/model/DmfTargetProperties.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...-repository-test/src/main/java/org/eclipse/hawkbit/repository/test/util/TestdataFactory.java
Outdated
Show resolved
Hide resolved
AmmarBikic
commented
Sep 19, 2019
...-repository-test/src/main/java/org/eclipse/hawkbit/repository/test/util/TestdataFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Nkyn
reviewed
Sep 23, 2019
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Show resolved
Hide resolved
Nkyn
reviewed
Sep 23, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
Nkyn
reviewed
Sep 24, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Show resolved
Hide resolved
Nkyn
reviewed
Sep 24, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
Nkyn
reviewed
Sep 24, 2019
...-repository-test/src/main/java/org/eclipse/hawkbit/repository/test/util/TestdataFactory.java
Show resolved
Hide resolved
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
…ATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
|
👍 |
Nkyn
approved these changes
Oct 1, 2019
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
|
The purpose of |
schabdo
reviewed
Oct 7, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
…ting the name property in THING_CREATED message Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
bogdan-bondar
requested changes
Oct 10, 2019
...dmf/hawkbit-dmf-api/src/main/java/org/eclipse/hawkbit/dmf/json/model/DmfAttributeUpdate.java
Outdated
Show resolved
Hide resolved
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
…l_name_to_thing_created # Conflicts: # docs/content/apis/dmf_api.md # hawkbit-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java # hawkbit-dmf/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java # hawkbit-repository/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/ControllerManagement.java # hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java # hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
...t-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerService.java
Outdated
Show resolved
Hide resolved
...f/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
schabdo
changed the title
AmmarBikic
added a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
* First implementation pushed because of debugging purpose Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Add name field and tests regarding name field functionality in THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * SonarQube realted changes in name field functionality in THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Add name field and tests regarding name field functionality in UPDATE_ATTRIBUTES Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Adapt documentation due to name field in THING_CREATED and UPDATE_ATTRIBUTES Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Add integration tests regarding name field functionality in THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Reformat after finding format bug regarding THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Reformat after finding the real format bug regarding THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Reformat regarding THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Use constant in THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Format in THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Resolving peer review comments regarding THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Resolving peer review comments (organize imports) regarding THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Refactoring regarding THING_CREATED Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Refactoring due to peer review Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Refactoring due to peer review Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Excluding UPDATE_ATTRIBUTES changes and provide functionality of updating the name property in THING_CREATED message Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Refactoring due to peer review Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Refactoring due to peer review Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Fix SonarQube finding Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Merge master into current branch Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com> * Fix peer review findings Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new optional filed "name" was added to the THING_CREATED message. It can also be used to update the name of an existing thing. Hence to that the documentation also needed to be updated.