Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check only DELETE_TARGET permission for deletion requests within target table #909

Conversation

herdt-michael
Copy link
Contributor

Remove check for Delete_Repository permission when creating TargetTable.

Signed-off-by: Michael Herdt Michael.Herdt2@bosch-si.com

…for TargetTable

Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
@hawkbit
Copy link

hawkbit bot commented Nov 11, 2019

Thanks for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution.
Please make sure you read the contribution guide and signed the Eclipse Contributor Agreement (ECA).

@hawkbit-bot
Copy link

Can one of the admins verify this patch?

…orSup

Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
@stefbehl stefbehl self-requested a review November 21, 2019 09:41
Copy link
Contributor

@stefbehl stefbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@stefbehl stefbehl merged commit e815873 into eclipse:master Nov 26, 2019
@stefbehl stefbehl deleted the feature_removeAddTargetAndUserPermissionsForSup branch November 26, 2019 11:54
@schabdo schabdo added this to the 0.3.0M6 milestone Dec 4, 2019
@schabdo schabdo changed the title Check only DELETE_TARGET permission by validating delete permissions … Check only DELETE_TARGET permission for deletion requests within target table Jan 16, 2020
AmmarBikic pushed a commit to bosch-io/hawkbit that referenced this pull request Oct 2, 2020
…for TargetTable (eclipse#909)

Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants