Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TTL for Connection Events #1714

Closed
alinaserg opened this issue Jan 20, 2020 · 2 comments · Fixed by #1923
Closed

Set TTL for Connection Events #1714

alinaserg opened this issue Jan 20, 2020 · 2 comments · Fixed by #1923
Assignees
Labels
Feature Request A request for adding new functionality to Hono good first issue Issues that do not require much in-depth knowledge of Hono
Milestone

Comments

@alinaserg
Copy link

There's a specific event message type "Connection events" to inform northbound application about the connection status of the device.

Right now it is not possible to set TTL for such type of events, it actually may cause storage problem, when there's no northbound application to which these connection events must be forwarded or when a northbound application listening only to telemetry messages. In such cases connection events won't be ever delivered to northbound application and won't be automatically deleted.

To prevent such cases TTL for Connection Events may be set and applied.

@sophokles73 sophokles73 added Feature Request A request for adding new functionality to Hono help wanted Issues that we would welcome any help from (new) contributors with good first issue Issues that do not require much in-depth knowledge of Hono labels Jan 20, 2020
@sophokles73 sophokles73 added this to the 1.2.0 milestone Feb 7, 2020
@sophokles73 sophokles73 modified the milestones: 1.2.0, 1.3.0 Mar 24, 2020
@Alfusainey
Copy link
Contributor

my understanding is that the current default implementation for this event type uses the downstream message sender implementation to send such events. this sender timeouts if the peer does not acknowledge receiving the message. does this solve the problem? am trying to understand how i can approach this

@sophokles73
Copy link
Contributor

@Alfusainey this is not about about timing out the sending, i.e. timing out while waiting for the broker's disposition frame. This is about how long the broker should keep the message in its queue, i.e. setting the message's ttl property accordingly ...

Alfusainey added a commit to Alfusainey/hono that referenced this issue Apr 23, 2020
fixes eclipse-hono#1714

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Apr 24, 2020
fixes eclipse-hono#1714

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
@sophokles73 sophokles73 removed the help wanted Issues that we would welcome any help from (new) contributors with label Apr 28, 2020
Alfusainey added a commit to Alfusainey/hono that referenced this issue Apr 28, 2020
fixes eclipse-hono#1714

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue May 6, 2020
fixes eclipse-hono#1714

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue May 6, 2020
The protocol adapters now use the max TTL configured for a tenant for connection event messages they emit.

Fixes #1714

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 added a commit that referenced this issue May 6, 2020
Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A request for adding new functionality to Hono good first issue Issues that do not require much in-depth knowledge of Hono
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants