Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a heap memory share reserved for GC #3273

Merged

Conversation

sophokles73
Copy link
Contributor

When calculating the maximum number of connections supported by a
protocol adapter, the "head room" on the heap that is required for the
garbage collector should be considered as well.

The MemoryBasedConnectionLimitStrategy has been adapted accordingly. The
protocol adapters now support a configuration property for explicitly
setting the percentage of the heap memory not to be used for the live
data-set. The default value is 25%.

When calculating the maximum number of connections supported by a
protocol adapter, the "head room" on the heap that is required for the
garbage collector should be considered as well.

The MemoryBasedConnectionLimitStrategy has been adapted accordingly. The
protocol adapters now support a configuration property for explicitly
setting the percentage of the heap memory not to be used for the live
data-set. The default value is 25%.

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
}

/**
* Gets the share of heap memory that should not be used by the live-data set but should be left
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets the share [...]

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
@sophokles73
Copy link
Contributor Author

@calohmn I have pushed a fix

Copy link
Contributor

@calohmn calohmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73 sophokles73 merged commit e2034c5 into eclipse-hono:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants