Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#643] AMQP adapter integration tests #740

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Alfusainey
Copy link
Contributor

@sophokles73: Integration tests for the AMQP adapter. This implementation uses ProtonClient instead of HonoClient. This patch relies on #739 to be merged first before the travis build can pass. If merged, i will rebase this PR

Signed-off-by: Alfusainey Jallow alf.jallow@gmail.com

@Alfusainey
Copy link
Contributor Author

@sophokles73: the travis build fails with The job exceeded the maximum time limit for jobs, and has been terminated. does adding a timeout for tests solve this?

@sophokles73
Copy link
Contributor

does adding a timeout for tests solve this?

this seems to happen once in a while when running our integration tests. I have no clue why. I have restarted the build. Let's see what happens ...

@Alfusainey
Copy link
Contributor Author

@sophokles73 it looks like the travis build passes now

@sophokles73
Copy link
Contributor

@Alfusainey please rebase ...

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
@Alfusainey
Copy link
Contributor Author

@sophokles73: rebased, thanks!

@sophokles73 sophokles73 merged commit 1f892a9 into eclipse-hono:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants