Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQP Protocol Adapter #643

Closed
Alfusainey opened this issue Jun 6, 2018 · 8 comments
Closed

AMQP Protocol Adapter #643

Alfusainey opened this issue Jun 6, 2018 · 8 comments
Assignees
@Alfusainey
Labels
enhancement
Milestone
0.7

Comments

@Alfusainey
Copy link
Contributor

This is a container issue for the AMQP protocol adapter. All PRs for the adapter will reference this issue
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 9, 2018
@Alfusainey
[eclipse-hono#643] Adds an additional test class whose setup simulate…
b58cb0c 
…s client devices using a ProtonClient. Remove modifications made to the example deployment and incorporates the comments provided by Kai in the pull request.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 9, 2018
@Alfusainey
[eclipse-hono#643] Fix merge conflicts resulting from pulling the pre…
3e867dc 
…vious PR.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>

Conflicts:
	adapters/amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/AmqpContext.java
	adapters/amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/Config.java
	adapters/amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/VertxBasedAmqpProtocolAdapter.java
	adapters/amqp-vertx/src/main/resources/logback-spring.xml
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 9, 2018
@Alfusainey
[eclipse-hono#643] Fix merge conflicts resulting from pulling the pre…
bcb5c5a 
…vious PR.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>

Conflicts:
	adapters/amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/AmqpContext.java
	adapters/amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/Config.java
	adapters/amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/VertxBasedAmqpProtocolAdapter.java
	adapters/amqp-vertx/src/main/resources/logback-spring.xml
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 9, 2018
@Alfusainey
[eclipse-hono#643] Minor changes
5049736 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 9, 2018
@Alfusainey
[eclipse-hono#643] Adds an additional test class whose setup simulate…
47b8250 
…s client devices using a ProtonClient. Remove modifications made to the example deployment and incorporates the comments provided by Kai in the pull request.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 11, 2018
@Alfusainey
[eclipse-hono#643] Remove additional test class
43473b2 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 11, 2018
@Alfusainey
[eclipse-hono#643] Fix according to Kai comments on Monday June 11th
d20b32b 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 11, 2018
@Alfusainey
[eclipse-hono#643] Fix according to Kai comments on Monday June 11th
464e5e5 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 13, 2018
@Alfusainey
[eclipse-hono#643] Add AmqpContext#handleFailure(...) to encapsulate …
89e78d0 
…releasing/rejecting dispositions

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 13, 2018
@Alfusainey
[eclipse-hono#643] Add AmqpContext#handleFailure(...) to encapsulate …
6203ae0 
…releasing/rejecting dispositions

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 13, 2018
@Alfusainey
[eclipse-hono#643] Add AmqpContext#handleFailure(...) to encapsulate …
e8090d0 
…releasing/rejecting dispositions

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 13, 2018
@Alfusainey
[eclipse-hono#643] An implementation of the AMQP adapter that allows …
faa9d10 
…unauthenticated devices publish telemetry and events to Hono.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 14, 2018
@Alfusainey
[eclipse-hono#643] Add tests for AMQP Adapter implementation (Unauthe…
b3381d4 
…nticated devices)

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Jun 14, 2018
@Alfusainey
[#643] An implementation of the AMQP adapter that allows unauthentica…
8083443 
…ted devices publish telemetry and events to Hono.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
@sophokles73 sophokles73 added this to the 0.7 milestone Jun 14, 2018
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 14, 2018
@Alfusainey
[eclipse-hono#643] Add tests for AMQP Adapter implementation (Unauthe…
7b058ee 
…nticated devices)

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 14, 2018
@Alfusainey
[eclipse-hono#643] AMQP Tests: adjust according to Kai comments on Ju…
f51669d 
…ne 14th

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 14, 2018
@Alfusainey
[eclipse-hono#643] AMQP Tests: adjust according to Kai comments on Ju…
dbe49c3 
…ne 14th

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
@Alfusainey
Copy link
Contributor Author

@sophokles73: i just want to follow-up on your previous comment regarding integration tests.
what do you think about adding the integration test for the amqp adapter (unauthenticated devices) before moving to the next step? like this i can have an initial test setup in the tests module before moving further. WDYT?

@sophokles73
Copy link
Contributor

Absolutely. Having an initial integration test that you can extend with additional test cases makes total sense to me.

Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 15, 2018
@Alfusainey
[eclipse-hono#643] Add tests for AMQP Adapter implementation (Unauthe…
f12f6c2 
…nticated devices)

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Jun 15, 2018
@Alfusainey
[#643] Add tests for AMQP Adapter implementation (Unauthenticated dev…
b1ca36a 
…ices)

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 20, 2018
@Alfusainey
[eclipse-hono#643] AMQP Adapter integration tests (unauthenticated de…
6b3467c 
…vices)

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 22, 2018
@Alfusainey
[eclipse-hono#643] AMQP Adapter integration tests (unauthenticated de…
a8299d1 
…vices)

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 22, 2018
@Alfusainey
[eclipse-hono#643] Remove fail ITs and fix bug in AMQP adapter
5855fcd 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 22, 2018
@Alfusainey
[eclipse-hono#643] BugFix: AMQP adapter uses the TenantId to check if…
ba783f0 
… the adapter was enabled/disabled for a tenant. The adapter name should have been used instead.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 24, 2018
@Alfusainey
[eclipse-hono#643] Remove fail ITs
1833c04 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Jun 25, 2018
@Alfusainey
[eclipse-hono#643] BugFix: AMQP adapter uses the TenantId to check if…
ab11cf2 
… the adapter was enabled/disabled for a tenant. The adapter name should have been used instead.

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 3, 2018
@Alfusainey
[eclipse-hono#643] Command-line client for interacting with the AMQP …
3fc8113 
…adapter

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 4, 2018
@Alfusainey
[#643] Command-line client for interacting with the AMQP adapter
1ba0b05 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 4, 2018
@Alfusainey
[#643] Command-line client for interacting with the AMQP adapter
991a177 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 4, 2018
@Alfusainey
[eclipse-hono#643] AMQP Adapter documentation for the Hono Website
a72fa15 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 4, 2018
@Alfusainey
[eclipse-hono#643] Integrate the AMQP adapter in the example deployment
ba135a0 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 4, 2018
@Alfusainey
[eclipse-hono#643] AMQP command-line client should also check for emp…
56d21a6 
…ty username and password (used by unauthenticated clients).

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 5, 2018
[#643] Do not invoke disconnect handler when peer closes connection.
213a753 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Aug 5, 2018
[#643] Run all interactions with adapter on same vert.x Context.
3f01f13 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 5, 2018
@Alfusainey
[eclipse-hono#643] Integrate the AMQP adapter in the example deployment
abf8483 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 5, 2018
@Alfusainey
[eclipse-hono#643] AMQP Adapter documentation for the Hono Website
969c19b 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 5, 2018
@Alfusainey
[eclipse-hono#643] AMQP command-line client should also check for emp…
4661ef3 
…ty username and password (used by unauthenticated clients).

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 5, 2018
@Alfusainey
[#643] AMQP command-line client should also check for empty username …
46e8e32 
…and password (used by unauthenticated clients).

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 5, 2018
@Alfusainey
[#643] AMQP Adapter documentation for the Hono Website
ba7f62b 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 8, 2018
@Alfusainey
[eclipse-hono#643] Integrate the AMQP adapter in the example deployment
a4a7432 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 8, 2018
@Alfusainey
[#643] Add AMQP adapter to example deployment scripts
86300ff 
AMQP adapter is now included in example deployment  scripts for
* Docker Swarm and
* Kubernetes

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 11, 2018
@Alfusainey
[eclipse-hono#643] Add support for client certificate based authentic…
e6fb992 
…ation

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 11, 2018
@Alfusainey
[eclipse-hono#643] Include documentation for SASL EXTERNAL auth on Ho…
823045e 
…no Website

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 11, 2018
@Alfusainey
[eclipse-hono#643] Include documentation for SASL EXTERNAL auth on Ho…
7ec8f7c 
…no Website

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 13, 2018
@Alfusainey
[eclipse-hono#643] Add support for client certificate based authentic…
c935ac4 
…ation

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 13, 2018
@Alfusainey
[eclipse-hono#643] Include documentation for SASL EXTERNAL auth on Ho…
ef9e991 
…no Website

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 13, 2018
@Alfusainey
[eclipse-hono#643] Add support for client certificate based authentic…
16a0b14 
…ation

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 13, 2018
@Alfusainey
[#643] Add support for client certificate based authentication
b293613 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 14, 2018
@Alfusainey
[eclipse-hono#643] Include documentation for SASL EXTERNAL auth on Ho…
eb99106 
…no Website

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey added a commit to Alfusainey/hono that referenced this issue Aug 14, 2018
@Alfusainey
[eclipse-hono#643] Include documentation for SASL EXTERNAL auth on Ho…
21838d9 
…no Website

Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 14, 2018
@Alfusainey
[#643] Include documentation for SASL EXTERNAL auth on Hono Website
87f21e5 
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
sophokles73 pushed a commit that referenced this issue Aug 14, 2018
[#643] Fix broken reference in documentation.
f502009 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
@sophokles73
Copy link
Contributor

fixed in f502009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alfusainey Alfusainey

Labels
enhancement
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
3 participants
@Alfusainey @sophokles73 @pho-enix