Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Migration of BATS to ICE #478

Merged
merged 6 commits into from Oct 28, 2020
Merged

Migration of BATS to ICE #478

merged 6 commits into from Oct 28, 2020

Conversation

marshallmcdonnell
Copy link

Fixes #475

Work includes:

  • Adding org.eclipse.ice.bats for the migration of BATS from @jayjaybillings GitHub account to ICE
  • Updated README
  • Updated license to EPL
  • Updated package to reflect move to org.eclipse.ice
  • Switch to tests from unit to integration tests and use failsafe-plugin
  • Refactor to use [docker-maven-plugin] (https://github.com/fabric8io/docker-maven-plugin) during tests since we have to spin up a Fuseki server during the integration tests
  • Adds .gitignore file to project

@marshallmcdonnell
Re eclipse#475 - Prepare BATS for migration to ICE
410760f 
Signed-off-by: Marshall McDonnell <mcdonnellmt@ornl.gov>
@marshallmcdonnell
Re eclipse#475 - update BATS README
689002f 
Signed-off-by: Marshall McDonnell <mcdonnellmt@ornl.gov>
@marshallmcdonnell
Re eclipse#475 - added BATS to org.eclipse.ice.build pom
de99f4e 
Signed-off-by: Marshall McDonnell <mcdonnellmt@ornl.gov>
@marshallmcdonnell marshallmcdonnell mentioned this pull request Oct 28, 2020
Closed
@jayjaybillings
Copy link
Member

I have never seen a more organized .gitignore! :)

@marshallmcdonnell
Copy link
Author

Ha, thanks but I always get them auto-generated from https://www.toptal.com/developers/gitignore (use to be https://www.gitignore.io).

I can take no credit 😁

jayjaybillings
jayjaybillings approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@jayjaybillings jayjaybillings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! If you wouldn't mind addressing some of these minor changes, I would appreciate it. None of these are blockers so I have approved it.

org.eclipse.ice.bats/README.md Outdated Show resolved Hide resolved
org.eclipse.ice.bats/README.md Outdated Show resolved Hide resolved
org.eclipse.ice.bats/README.md Show resolved Hide resolved
org.eclipse.ice.bats/pom.xml Outdated Show resolved Hide resolved
org.eclipse.ice.bats/src/main/docker/Dockerfile.fuseki Show resolved Hide resolved
org.eclipse.ice.bats/src/main/docker/dataset.ttl Outdated Show resolved Hide resolved
org.eclipse.ice.bats/src/test/java/gov/ornl/rse/tests/bats/ITDataSet.java Show resolved Hide resolved
@marshallmcdonnell
Re eclipse#475 - fixing typos in BATS README
7f3b8e1 
Signed-off-by: Marshall McDonnell <mcdonnellmt@ornl.gov>
@marshallmcdonnell
Re eclipse#475 - bump Java version from 8 -> 11 for BATS
548b2d9 
Signed-off-by: Marshall McDonnell <mcdonnellmt@ornl.gov>
@marshallmcdonnell
Re eclipse#475 - remove unnecessary turtle file for BATS docker setup
5f4633f 
Signed-off-by: Marshall McDonnell <mcdonnellmt@ornl.gov>
@marshallmcdonnell
Copy link
Author

Thanks for the review, @jayjaybillings, much appreciated!
I believe I have all the comments / issues resolved now.

For anyone, feel free to let me know if there is anything else I can do or need to change!
Otherwise, assuming everything on my part is done and will wait for a merge

@jayjaybillings
Copy link
Member

Seeing as this meets the all the checks and has an approval, I am very happy to accept this PR. Thank you!

@jayjaybillings jayjaybillings merged commit f229eb4 into eclipse:next Oct 28, 2020
@marshallmcdonnell marshallmcdonnell deleted the marshall/bats_migration branch October 29, 2020 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jayjaybillings jayjaybillings jayjaybillings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marshallmcdonnell @jayjaybillings