Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport javax.measure.unit-api? #278

Closed
tschoonj opened this issue Dec 14, 2017 · 2 comments
Closed

Reexport javax.measure.unit-api? #278

tschoonj opened this issue Dec 14, 2017 · 2 comments

Comments

@tschoonj
Copy link
Contributor

When using the UnitMetadata class, I noticed getting a build path error for javax.measure.Unit. I fixed it by adding a bundle requirement for javax.measure.unit-api, but perhaps it would be better to reexport this bundle in the org.eclipse.january MANIFEST.MF?
@PeterC-DLS
Copy link
Contributor

Yes, please!

@tschoonj
Copy link
Contributor Author

Ok, will open PR

tschoonj added a commit to tschoonj/january that referenced this issue Dec 14, 2017
@tschoonj
MANIFEST: reexport javax.measure.unit-api
720dfc3 
Closes eclipse#278

Signed-off-by: Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>
tschoonj added a commit to tschoonj/january that referenced this issue Dec 14, 2017
@tschoonj
MANIFEST: reexport javax.measure.unit-api
4bfe7de 
Closes eclipse#278

Signed-off-by: Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>
PeterC-DLS pushed a commit that referenced this issue Mar 5, 2018
@tschoonj @PeterC-DLS
MANIFEST: reexport javax.measure.unit-api (#279)
705cc56 
Closes #278

Signed-off-by: Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>
PeterC-DLS pushed a commit that referenced this issue Mar 5, 2018
@tschoonj @PeterC-DLS
MANIFEST: reexport javax.measure.unit-api (#279)
8cec54b 
Closes #278

Signed-off-by: Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>
PeterC-DLS pushed a commit that referenced this issue Jun 29, 2018
@tschoonj @PeterC-DLS
MANIFEST: reexport javax.measure.unit-api (#279)
b29ffa1 
Closes #278

Signed-off-by: Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>
@PeterC-DLS PeterC-DLS mentioned this issue Jun 29, 2018
Merged
PeterC-DLS pushed a commit that referenced this issue Jun 29, 2018
@tschoonj @PeterC-DLS
MANIFEST: reexport javax.measure.unit-api (#279)
291dd87 
Closes #278

Signed-off-by: Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>
Signed-off-by: Peter Chang <peter.chang@diamond.ac.uk>
PeterC-DLS added a commit that referenced this issue Jun 29, 2018
@PeterC-DLS
MANIFEST: reexport javax.measure.unit-api (#279) (#327)
610ce98 
Closes #278

Signed-off-by: Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>
Signed-off-by: Peter Chang <peter.chang@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tschoonj @PeterC-DLS