Add unit metadata2 #256
Merged
Add unit metadata2 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Baha El-Kassaby <baha.elkassaby@gmail.com>
|
the target and tpd files need to have their orbit location updated with : |
|
#258 is the updated pull request... however the ip-validation is still failing... this might be due to the merge and in my last commit I should have added noreply@github as a committer too... Will try to sort that out tomorrow... |
Signed-off-by: Baha El-Kassaby <baha.elkassaby@gmail.com>
Closed
|
could you update this pull request with my latest commits in #259 ? once more an ip-validation failure... |
Closed
Signed-off-by: Baha El-Kassaby <baha.elkassaby@gmail.com>
|
Closes #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.