Skip to content

Commit

Permalink
460671 - Rationalize property names.
Browse files Browse the repository at this point in the history
Property format is now "jetty.<module|component>.<propertyName>".

Updated all references with new properties.
  • Loading branch information
sbordet committed Apr 13, 2015
1 parent d78673f commit 599ab9b
Show file tree
Hide file tree
Showing 138 changed files with 1,198 additions and 1,043 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public static void main(String[] args)
{
String jetty_home = System.getProperty("jetty.home",".");

Server server = new Server(Integer.getInteger("jetty.port",8080).intValue());
Server server = new Server(Integer.getInteger("jetty.http.port",8080).intValue());

WebAppContext webapp = new WebAppContext();
webapp.setContextPath("/");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@
<Arg>
<New id="alpn" class="org.eclipse.jetty.alpn.server.ALPNServerConnectionFactory">
<Arg type="String">
<Property name="alpn.protocols" default="" />
<Property name="jetty.alpn.protocols,alpn.protocols" default="" />
</Arg>
<Set name="defaultProtocol">
<Property name="alpn.defaultProtocol" />
<Property name="jetty.alpn.defaultProtocol,alpn.defaultProtocol" />
</Set>
</New>
</Arg>
</Call>

<!-- Enables ALPN debugging on System.err -->
<!--<Set class="org.eclipse.jetty.alpn.ALPN" name="debug" type="boolean">true</Set>-->
<!-- ALPN debugging on System.err -->
<Set class="org.eclipse.jetty.alpn.ALPN" name="debug" type="boolean"><Property name="jetty.alpn.debug" default="false" /></Set>

</Configure>

7 changes: 5 additions & 2 deletions jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn.mod
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,13 @@ lib/alpn/
# Overrides the order protocols are chosen by the server.
# The default order is that specified by the order of the
# modules declared in start.ini.
# alpn.protocols=h2-14,http/1.1
# jetty.alpn.protocols=h2-16,http/1.1

# Specifies what protocol to use when negotiation fails.
# alpn.defaultProtocol=http/1.1
# jetty.alpn.defaultProtocol=http/1.1

# ALPN debug logging on System.err
# jetty.alpn.debug=false

[license]
ALPN is a hosted at github under the GPL v2 with ClassPath Exception.
Expand Down
2 changes: 1 addition & 1 deletion jetty-cdi/test-cdi-it/src/test/scripts/start-jetty.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ echo \${jetty.base} : $JETTY_BASE
cd "$JETTY_BASE"

"$JAVA_HOME/bin/java" -jar "$JETTY_HOME/start.jar" \
jetty.port=58080 \
jetty.http.port=58080 \
STOP.PORT=58181 STOP.KEY=it


2 changes: 1 addition & 1 deletion jetty-deploy/src/main/config/etc/jetty-deploy.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<Call id="webappprovider" name="addAppProvider">
<Arg>
<New class="org.eclipse.jetty.deploy.providers.WebAppProvider">
<Set name="monitoredDirName"><Property name="jetty.base" default="." />/<Property name="jetty.deploy.monitoredDirName" default="webapps"/></Set>
<Set name="monitoredDirName"><Property name="jetty.base" default="." />/<Property name="jetty.deploy.monitoredDir,jetty.deploy.monitoredDirName" default="webapps"/></Set>
<Set name="defaultsDescriptor"><Property name="jetty.home" default="." />/etc/webdefault.xml</Set>
<Set name="scanInterval"><Property name="jetty.deploy.scanInterval" default="1"/></Set>
<Set name="extractWars"><Property name="jetty.deploy.extractWars" default="true"/></Set>
Expand Down
10 changes: 7 additions & 3 deletions jetty-deploy/src/main/config/modules/deploy.mod
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ webapps/
etc/jetty-deploy.xml

[ini-template]
## DeployManager configuration
# Monitored Directory name (relative to jetty.base)
# jetty.deploy.monitoredDirName=webapps
# Monitored directory name (relative to jetty.base)
# jetty.deploy.monitoredDir=webapps

# Monitored directory scan period (seconds)
# jetty.deploy.scanInterval=1

# Whether to extract *.war files
# jetty.deploy.extractWars=true
12 changes: 6 additions & 6 deletions jetty-deploy/src/test/resources/jetty.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
<Arg name="threadpool"><New id="threadpool" class="org.eclipse.jetty.util.thread.QueuedThreadPool"/></Arg>
-->
<Get name="ThreadPool">
<Set name="minThreads" type="int"><Property name="threads.min" default="10"/></Set>
<Set name="maxThreads" type="int"><Property name="threads.max" default="200"/></Set>
<Set name="idleTimeout" type="int"><Property name="threads.timeout" default="60000"/></Set>
<Set name="minThreads" type="int"><Property name="jetty.threadPool.minThreads" default="10"/></Set>
<Set name="maxThreads" type="int"><Property name="jetty.threadPool.maxThreads" default="200"/></Set>
<Set name="idleTimeout" type="int"><Property name="jetty.threadPool.idleTimeout" default="60000"/></Set>
<Set name="detailedDump">false</Set>
</Get>

Expand Down Expand Up @@ -78,7 +78,7 @@
<!-- =========================================================== -->
<New id="httpConfig" class="org.eclipse.jetty.server.HttpConfiguration">
<Set name="secureScheme">https</Set>
<Set name="securePort" type="java.lang.Integer"><Property name="jetty.secure.port" default="8443" /></Set>
<Set name="securePort" type="java.lang.Integer"><Property name="jetty.httpConfig.securePort" default="8443" /></Set>
<Set name="outputBufferSize">32768</Set>
<Set name="requestHeaderSize">8192</Set>
<Set name="responseHeaderSize">8192</Set>
Expand Down Expand Up @@ -125,7 +125,7 @@
<!-- =========================================================== -->
<Set name="stopAtShutdown">true</Set>
<Set name="stopTimeout">5000</Set>
<Set name="dumpAfterStart"><Property name="jetty.dump.start" default="false"/></Set>
<Set name="dumpBeforeStop"><Property name="jetty.dump.stop" default="false"/></Set>
<Set name="dumpAfterStart"><Property name="jetty.server.dumpAfterStart" default="false"/></Set>
<Set name="dumpBeforeStop"><Property name="jetty.server.dumpBeforeStop" default="false"/></Set>

</Configure>
2 changes: 1 addition & 1 deletion jetty-distribution/src/main/resources/bin/jetty.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ NAME=$(echo $(basename $0) | sed -e 's/^[SK][0-9]*//' -e 's/\.sh$//')
# JETTY_ARGS
# The default arguments to pass to jetty.
# For example
# JETTY_ARGS=jetty.port=8080 jetty.secure.port=443
# JETTY_ARGS=jetty.http.port=8080 jetty.ssl.port=8443
#
# JETTY_USER
# if set, then used as a username to run the server as
Expand Down
10 changes: 5 additions & 5 deletions jetty-distribution/src/main/resources/etc/hawtio.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
<Call name="addHandler">
<Arg>
<New class="org.eclipse.jetty.webapp.WebAppContext">
<Set name="contextPath">/hawtio</Set>
<Set name="war"><Property name="jetty.base" default="."/>/lib/hawtio/hawtio.war</Set>
<Set name="extractWAR">true</Set>
<Set name="copyWebDir">false</Set>
<Set name="defaultsDescriptor"><Property name="jetty.home" default="."/>/etc/webdefault.xml</Set>
<Set name="contextPath">/hawtio</Set>
<Set name="war"><Property name="jetty.base" default="."/>/lib/hawtio/hawtio.war</Set>
<Set name="extractWAR">true</Set>
<Set name="copyWebDir">false</Set>
<Set name="defaultsDescriptor"><Property name="jetty.home" default="."/>/etc/webdefault.xml</Set>
</New>
</Arg>
</Call>
Expand Down
14 changes: 7 additions & 7 deletions jetty-distribution/src/main/resources/etc/jamon.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@
<Ref refid="Contexts">
<Call name="addHandler">
<Arg>
<New class="org.eclipse.jetty.webapp.WebAppContext">
<Set name="contextPath">/jamon</Set>
<Set name="war"><Property name="jetty.base" default="."/>/lib/jamon/jamon.war</Set>
<Set name="extractWAR">true</Set>
<Set name="copyWebDir">false</Set>
<Set name="defaultsDescriptor"><Property name="jetty.home" default="."/>/etc/webdefault.xml</Set>
</New>
<New class="org.eclipse.jetty.webapp.WebAppContext">
<Set name="contextPath">/jamon</Set>
<Set name="war"><Property name="jetty.base" default="."/>/lib/jamon/jamon.war</Set>
<Set name="extractWAR">true</Set>
<Set name="copyWebDir">false</Set>
<Set name="defaultsDescriptor"><Property name="jetty.home" default="."/>/etc/webdefault.xml</Set>
</New>
</Arg>
</Call>
</Ref>
Expand Down
2 changes: 1 addition & 1 deletion jetty-distribution/src/main/resources/etc/jminix.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0"?>
<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "http://www.eclipse.org/jetty/configure.dtd">
<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "http://www.eclipse.org/jetty/configure_9_0.dtd">

<Configure id="Server" class="org.eclipse.jetty.server.Server">
<Call name="addBean">
Expand Down
10 changes: 5 additions & 5 deletions jetty-distribution/src/main/resources/etc/jolokia.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
<Call name="addHandler">
<Arg>
<New class="org.eclipse.jetty.webapp.WebAppContext">
<Set name="contextPath">/jolokia</Set>
<Set name="war"><Property name="jetty.base" default="."/>/lib/jolokia/jolokia.war</Set>
<Set name="extractWAR">true</Set>
<Set name="copyWebDir">false</Set>
<Set name="defaultsDescriptor"><Property name="jetty.home" default="."/>/etc/webdefault.xml</Set>
<Set name="contextPath">/jolokia</Set>
<Set name="war"><Property name="jetty.base" default="."/>/lib/jolokia/jolokia.war</Set>
<Set name="extractWAR">true</Set>
<Set name="copyWebDir">false</Set>
<Set name="defaultsDescriptor"><Property name="jetty.home" default="."/>/etc/webdefault.xml</Set>
</New>
</Arg>
</Call>
Expand Down
2 changes: 1 addition & 1 deletion jetty-fcgi/fcgi-server/src/main/config/modules/fcgi.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ lib/fcgi/*.jar
[ini-template]
## For configuration of FastCGI contexts, see
## TODO: documentation url here
## https://www.eclipse.org/jetty/documentation/current/fastcgi.html
3 changes: 2 additions & 1 deletion jetty-http2/http2-server/src/main/config/etc/jetty-http2.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
<Arg>
<New class="org.eclipse.jetty.http2.server.HTTP2ServerConnectionFactory">
<Arg name="config"><Ref refid="sslHttpConfig"/></Arg>
<Set name="maxConcurrentStreams"><Property name="http2.maxConcurrentStreams" default="1024"/></Set>
<Set name="maxConcurrentStreams"><Property name="jetty.http2.maxConcurrentStreams,http2.maxConcurrentStreams" default="1024"/></Set>
<Set name="initialStreamSendWindow"><Property name="jetty.http2.initialStreamSendWindow" default="65535"/></Set>
</New>
</Arg>
</Call>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
<Arg>
<New class="org.eclipse.jetty.http2.server.HTTP2CServerConnectionFactory">
<Arg name="config"><Ref refid="httpConfig"/></Arg>
<Set name="maxConcurrentStreams"><Property name="http2.maxConcurrentStreams" default="1024"/></Set>
<Set name="maxConcurrentStreams"><Property name="jetty.http2.maxConcurrentStreams,http2.maxConcurrentStreams" default="1024"/></Set>
<Set name="initialStreamSendWindow"><Property name="jetty.http2.initialStreamSendWindow" default="65535"/></Set>
</New>
</Arg>
</Call>
Expand Down
6 changes: 4 additions & 2 deletions jetty-http2/http2-server/src/main/config/modules/http2.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ lib/http2/*.jar
etc/jetty-http2.xml
[ini-template]
## HTTP2 Configuration
## Max number of concurrent streams per connection
# jetty.http2.maxConcurrentStreams=1024
# http2.maxConcurrentStreams=1024
## Initial stream send (server to client) window
# jetty.http2.initialStreamSendWindow=65535
14 changes: 7 additions & 7 deletions jetty-http2/http2-server/src/main/config/modules/http2c.mod
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#
# HTTP2 Clear Text Support Module
# This module adds support for HTTP/2 clear text to the
# HTTP/1 clear text connector (defined in jetty-http.xml).
# The resulting connector will accept both HTTP/1 and HTTP/2 connections.
#

[depend]
Expand All @@ -12,11 +15,8 @@ lib/http2/*.jar
etc/jetty-http2c.xml
[ini-template]
## HTTP2c Configuration
# This module adds support for HTTP/2 clear text to the
# HTTP/1 clear text connector (defined in jetty-http.xml)
# The resulting connector will accept both HTTP/1 and HTTP/2
# connections
## Max number of concurrent streams per connection
# jetty.http2.maxConcurrentStreams=1024
# http2.maxConcurrentStreams=1024
## Initial stream send (server to client) window
# jetty.http2.initialStreamSendWindow=65535
15 changes: 4 additions & 11 deletions jetty-io/src/main/java/org/eclipse/jetty/io/SelectorManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import java.util.concurrent.Executor;

import org.eclipse.jetty.util.TypeUtil;
import org.eclipse.jetty.util.annotation.ManagedAttribute;
import org.eclipse.jetty.util.component.AbstractLifeCycle;
import org.eclipse.jetty.util.component.ContainerLifeCycle;
import org.eclipse.jetty.util.component.Dumpable;
Expand Down Expand Up @@ -97,23 +96,17 @@ public void setConnectTimeout(long milliseconds)
_connectTimeout = milliseconds;
}

@ManagedAttribute("The priority delta to apply to selector threads")
/**
* @deprecated not implemented
*/
@Deprecated
public int getSelectorPriorityDelta()
{
return 0;
}

/**
* Sets the selector thread priority delta to the given amount.
* <p>This allows the selector threads to run at a different priority.
* Typically this would be used to lower the priority to give preference
* to handling previously accepted connections rather than accepting
* new connections.</p>
*
* @param selectorPriorityDelta the amount to change the thread priority
* delta to (may be negative)
* @see Thread#getPriority()
* @deprecated not implemented
*/
@Deprecated
public void setSelectorPriorityDelta(int selectorPriorityDelta)
Expand Down
3 changes: 1 addition & 2 deletions jetty-jaas/src/main/config/etc/jetty-jaas.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@

<Configure id="Server" class="org.eclipse.jetty.server.Server">


<!-- ======================================================== -->
<!-- java.security.auth.login.config System property -->
<!-- This is usually a runtime parameter to the jvm, but -->
<!-- it is placed here for convenience. -->
<!-- ======================================================== -->
<Call class="java.lang.System" name="setProperty">
<Arg>java.security.auth.login.config</Arg>
<Arg><Property name="jetty.base" default="." />/<Property name="jaas.login.conf" default="etc/login.conf"/></Arg>
<Arg><Property name="jetty.base" default="." />/<Property name="jetty.jaas.login.conf,jaas.login.conf" default="etc/login.conf"/></Arg>
</Call>

</Configure>
5 changes: 3 additions & 2 deletions jetty-jaas/src/main/config/modules/jaas.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ lib/jetty-jaas-${jetty.version}.jar
etc/jetty-jaas.xml

[ini-template]
## JAAS Configuration
jaas.login.conf=etc/login.conf
## The file location (relative to $jetty.base) for the
## JAAS "java.security.auth.login.config" system property
# jetty.jaas.login.conf=etc/login.conf
43 changes: 27 additions & 16 deletions jetty-jmx/src/main/config/etc/jetty-jmx-remote.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,38 @@
<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "http://www.eclipse.org/jetty/configure_9_0.dtd">

<Configure id="Server" class="org.eclipse.jetty.server.Server">
<!-- =========================================================== -->
<!-- Set the java.rmi.server.hostname property in case you've -->
<!-- got a misconfigured /etc/hosts entry or the like. -->
<!-- =========================================================== -->
<!--
<Call class="java.lang.System" name="setProperty">
<Arg>java.rmi.server.hostname</Arg>
<Arg>127.0.0.1</Arg>
</Call>
-->

<!-- Add a remote JMX connector. The parameters of the constructor
below specify the JMX service URL, and the object name string for the
connector server bean. The parameters of the JMXServiceURL constructor
specify the protocol that clients will use to connect to the remote JMX
connector (RMI), the hostname of the server (local hostname), port number
(automatically assigned), and the URL path. Note that URL path contains
the RMI registry hostname and port number, that may need to be modified
in order to comply with the firewall requirements.
below specify the JMX service URL, and the object name string for the
connector server bean. The parameters of the JMXServiceURL constructor
specify the protocol that clients will use to connect to the remote JMX
connector (RMI), the hostname of the server (local hostname), port number
(automatically assigned), and the URL path. Note that URL path contains
the RMI registry hostname and port number, that may need to be modified
in order to comply with the firewall requirements.
-->
<Call name="addBean">
<Arg>
<New id="ConnectorServer" class="org.eclipse.jetty.jmx.ConnectorServer">
<Arg>
<New class="javax.management.remote.JMXServiceURL">
<Arg type="java.lang.String">rmi</Arg>
<Arg type="java.lang.String" />
<Arg type="java.lang.Integer"><Property name="jetty.jmxrmiport" default="1099"/></Arg>
<Arg type="java.lang.String">/jndi/rmi://<Property name="jetty.jmxrmihost" default="localhost"/>:<Property name="jetty.jmxrmiport" default="1099"/>/jmxrmi</Arg>
</New>
</Arg>
<Arg>org.eclipse.jetty.jmx:name=rmiconnectorserver</Arg>
<Arg>
<New class="javax.management.remote.JMXServiceURL">
<Arg type="java.lang.String">rmi</Arg>
<Arg type="java.lang.String"><Property name="jetty.jmxremote.rmihost,jetty.jmxrmihost" default="localhost"/></Arg>
<Arg type="java.lang.Integer"><Property name="jetty.jmxremote.rmiport,jetty.jmxrmiport" default="1099"/></Arg>
<Arg type="java.lang.String">/jndi/rmi://<Property name="jetty.jmxremote.rmihost,jetty.jmxrmihost" default="localhost"/>:<Property name="jetty.jmxremote.rmiport,jetty.jmxrmiport" default="1099"/>/jmxrmi</Arg>
</New>
</Arg>
<Arg>org.eclipse.jetty.jmx:name=rmiconnectorserver</Arg>
</New>
</Arg>
</Call>
Expand Down
11 changes: 0 additions & 11 deletions jetty-jmx/src/main/config/etc/jetty-jmx.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,6 @@

<Configure id="Server" class="org.eclipse.jetty.server.Server">

<!-- =========================================================== -->
<!-- Set the java.rmi.server.hostname property in case you've -->
<!-- got a misconfigured /etc/hosts entry or the like. -->
<!-- =========================================================== -->
<!--
<Call class="java.lang.System" name="setProperty">
<Arg>java.rmi.server.hostname</Arg>
<Arg>127.0.0.1</Arg>
</Call>
-->

<!-- =========================================================== -->
<!-- Get the platform mbean server -->
<!-- =========================================================== -->
Expand Down
12 changes: 5 additions & 7 deletions jetty-jmx/src/main/config/modules/jmx-remote.mod
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@ jmx
etc/jetty-jmx-remote.xml

[ini-template]
## JMX Configuration
## Enable for an open port accessible by remote machines
# jetty.jmxrmihost=localhost
# jetty.jmxrmiport=1099
## Strictly speaking you shouldn't need --exec to use this in most environments.
## If this isn't working, make sure you enable --exec as well
# -Dcom.sun.management.jmxremote
## The host/address to bind RMI to
# jetty.jmxremote.rmihost=localhost

## The port RMI listens to
# jetty.jmxremote.rmiport=1099
Loading

0 comments on commit 599ab9b

Please sign in to comment.