Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct websocket artifactIds on jetty-10.0.x #3288

Closed
joakime opened this issue Jan 23, 2019 · 1 comment
Closed

Correct websocket artifactIds on jetty-10.0.x #3288

joakime opened this issue Jan 23, 2019 · 1 comment
Assignees
@joakime

Comments

@joakime
Copy link
Contributor

joakime commented Jan 23, 2019

The websocket artifactIds on jetty-10.0.x are not matching the directory names.

We changed the artifactIds on the javax.websocket artifacts

  • javax-websocket-client-impl -> javax-websocket-client
  • javax-websocket-server-impl -> javax-websocket-server

But the artifactIds for the Jetty WebSocket API were not updated in the same process.

  • /jetty-websocket/jetty-websocket-client is <artifactId>websocket-client</artifactId>
  • /jetty-websocket/jetty-websocket-server is <artifactId>websocket-server</artifactId>

We should update the artifactIds to indicate the API as well.
@joakime joakime self-assigned this Jan 23, 2019
joakime added a commit that referenced this issue Jan 23, 2019
@joakime
Issue #3288 - Correcting Jetty WebSocket API artifactIds
5095c8a 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor Author

joakime commented Jan 23, 2019

Opened PR #3289

joakime added a commit that referenced this issue Jan 24, 2019
@joakime
Merge pull request #3289 from eclipse/jetty-10.0.x-websocket-artifact…
02dd7d1 
…-ids

Issue #3288 - Correcting Jetty WebSocket API artifactIds
@joakime joakime closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joakime