Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of unconsumed content #6168

Closed
sbordet opened this issue Apr 13, 2021 · 2 comments · Fixed by #6163
Closed

Improve handling of unconsumed content #6168

sbordet opened this issue Apr 13, 2021 · 2 comments · Fixed by #6163

Comments

@sbordet
Copy link
Contributor

@sbordet sbordet commented Apr 13, 2021

Jetty version
9.4.x

Description
The case of unconsumed content, and HttpInput.Interceptor throwing an exception, should be handled better.
In particular, make sure that exceptions thrown by the interceptor are correctly handled.

@sbordet
Copy link
Contributor Author

@sbordet sbordet commented Apr 13, 2021

See also #6167.

sbordet added a commit that referenced this issue Apr 13, 2021
Added or expanded the scope of catch blocks to properly handle exceptions thrown by `HttpInput.Interceptor`.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@gregw
Copy link
Contributor

@gregw gregw commented Apr 13, 2021

Also, whilst doing a consumeAll, the interceptors should not be called as that can waste CPU and memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
@gregw @joakime @sbordet and others