inherit plugin versions from main pom #2897
Conversation
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
pom.xml
Outdated
| <maven.version>3.5.0</maven.version> | ||
| <unix.socket.tmp></unix.socket.tmp> | ||
|
|
||
| <!-- some maven plugins versions --> | ||
| <surefire.version>2.22.0</surefire.version> |
There was a problem hiding this comment.
Can we make this have the same format of the others, i.e. maven.surefire.plugin.version?
pom.xml
Outdated
| <maven.resources.plugin.version>3.1.0</maven.resources.plugin.version> | ||
| <maven.source.plugin.version>3.0.1</maven.source.plugin.version> | ||
| <maven.war.plugin.version>3.2.2</maven.war.plugin.version> | ||
| <maven-plugin-tools.version>3.5.2</maven-plugin-tools.version> |
There was a problem hiding this comment.
Ditto, same format as others here?
There was a problem hiding this comment.
I actually prefer the format maven.plugin.xxx.version so that it's immediate that they are maven plugin related properties.
| <artifactId>it-parent-pom</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <groupId>org.eclipse.jetty.its.jetty-cdi-run-forked-mojo-it</groupId> | ||
| <artifactId>jetty-weld-minimal</artifactId> | ||
| <version>1.0-SNAPSHOT</version> |
There was a problem hiding this comment.
The version is not necessary now that there is a parent, I would removed it from all children POMs - less duplication.
There was a problem hiding this comment.
I don't get the need of this one. There is no reason to have parent and child having same version.
Please bear in mind it's ONLY test projects which are not deployed anywhere and versions will NEVER change!
this it parent pom is purely convenient to have common version in all TEST projects. Which is again not mandatory.
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy oliver.lamy@gmail.com