Cleanups to WebSocket CloseStatus #5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Nov 25, 2020
| @@ -343,6 +331,8 @@ public static String codeString(int closeStatus) | |||
| return "PROTOCOL"; | |||
| case BAD_DATA: | |||
| return "BAD_DATA"; | |||
| case RESERVED: | |||
There was a problem hiding this comment.
Rather than have this switch here, that has to be maintained, it really feels like we should have an enum with both the code and the string.... hmmmm
There was a problem hiding this comment.
It's difficult because we aren't restricted to these defined values here, it could be any int within the 1000-5000 range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isTransmittableStatusCode(int)method.