Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GC log analysis support #106

Merged
merged 12 commits into from Jan 26, 2022
Merged

feat: GC log analysis support #106

merged 12 commits into from Jan 26, 2022

Conversation

leveretconey
Copy link
Contributor

@leveretconey leveretconey commented Jan 17, 2022

Hi all,

This is the implementation of #107 . Target to add gclog analysis to help user deal with garbage collection issues.

Please review. Any suggestion is appreciated.

Thanks.

@D-D-H D-D-H changed the title feat: gclog analysis feat: GC log analysis support Jan 19, 2022
@leveretconey
Copy link
Contributor Author

Hi, all. I give some additional information about how the feature is implemented to help you review the code.

Then main entrance of the feature is in GCLogAnalyzer.parse. There are 3 main steps :

  1. GCLogParser will parse the original GC log file into GCEvents, recording direct information from the file. This is done by first recognizing the format and collector of the log, then parse each line using corresponding parsing rules.

  2. GCModel.calculateDerivedInfo will calculate more metrics we can get from original info, such as promotion of single event and max pause time of the whole process. All these data are saved in GCModel.

  3. Frontend pages displays information through gclog backend apis.

Please review. Thanks.

implementation project(':backend:common')

testImplementation group: 'junit', name: 'junit', version: "4.12"
testImplementation group: 'io.vertx', name: 'vertx-unit', version: "3.7.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${vertx_version}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@D-D-H D-D-H mentioned this pull request Jan 21, 2022
@D-D-H D-D-H merged commit 1599c35 into eclipse:master Jan 26, 2022
@leveretconey leveretconey deleted the gclog_jifa branch February 9, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants