Migrated jnosql-arangodb-extension into the jnosql-arangodb module;
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
…clipse.jnosql.databases Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
|
@otaviojava could you review this PR, please? |
|
Can one of the admins verify this patch? |
otaviojava
reviewed
Apr 3, 2023
pom.xml
Outdated
| @@ -103,6 +104,18 @@ | |||
| <artifactId>jnosql-mapping-key-value</artifactId> | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I've updated the pom parent; we don't need this anymore.
Could you check it, please?
There was a problem hiding this comment.
@otaviojava, it's done!
|
@dearrudam please, update your branch to take the newest code from the main branch.
|
|
About the package, please, use:
|
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
…ures Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
|
@otaviojava, please, review this one?! |
…ures Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
otaviojava
reviewed
Apr 3, 2023
| import java.lang.annotation.Target; | ||
|
|
||
| /** | ||
| * To a dynamic query on ArangoDBRepository and ArangoDBRepositoryAsync interfaces. |
There was a problem hiding this comment.
There is no ArangoDBRepositoryAsync could you update this one on another PR?
otaviojava
reviewed
Apr 3, 2023
| @Target(ElementType.METHOD) | ||
| public @interface AQL { | ||
|
|
||
| String value(); |
There was a problem hiding this comment.
on another PR, could you document this annotation?
otaviojava
approved these changes
Apr 3, 2023
otaviojava
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: eclipse/jnosql#355
Changes
jnosql-arangodb-extensioninto thejnosql-arangodbmodule;