fix(batch-jobs): Add max length to configuration put step definition.

A configuration cannot have more than 65535 characters, due to the database column `TEXT` definition. Adding the validation in the frontend permits to fail fast illegal requests without sending them to the backend. Also add check on backend.
eclipse · Jul 17, 2023 · 0514a90 · 0514a90
1 parent de55b3a
commit 0514a90
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...src/main/java/org/eclipse/kapua/app/console/module/job/client/steps/JobStepAddDialog.java b/...src/main/java/org/eclipse/kapua/app/console/module/job/client/steps/JobStepAddDialog.java
@@ -314,6 +314,7 @@ protected void refreshJobStepDefinition(GwtJobStepDefinition gwtJobStepDefinitio
 
                 textArea.setData(PROPERTY_TYPE, property.getPropertyType());
                 textArea.setData(PROPERTY_NAME, property.getPropertyName());
+                textArea.setMaxLength(65535);
                 jobStepPropertiesPanel.add(textArea);
 
                 if (property.getExampleValue() != null) {

diff --git a/...nternal/src/main/java/org/eclipse/kapua/service/job/step/internal/JobStepServiceImpl.java b/...nternal/src/main/java/org/eclipse/kapua/service/job/step/internal/JobStepServiceImpl.java
@@ -88,6 +88,11 @@ public JobStep create(JobStepCreator jobStepCreator) throws KapuaException {
         ArgumentValidator.validateEntityName(jobStepCreator.getName(), "jobStepCreator.name");
         ArgumentValidator.notNull(jobStepCreator.getJobStepDefinitionId(), "jobStepCreator.stepDefinitionId");
 
+        for (JobStepProperty jobStepProperty : jobStepCreator.getStepProperties()) {
+            Integer stepPropertyMaxLength = jobStepProperty.getMaxLength() != null ? jobStepProperty.getMaxLength() : 65535;
+            ArgumentValidator.lengthRange(jobStepProperty.getPropertyValue(), jobStepProperty.getMinLength(), stepPropertyMaxLength, "stepProperties[]." + jobStepProperty.getName());
+        }
+
         if (jobStepCreator.getDescription() != null) {
             ArgumentValidator.numRange(jobStepCreator.getDescription().length(), 0, 8192, "jobStepCreator.description");
         }