Improved TransportException implementation

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>

transport/api/src/main/java/org/eclipse/kapua/transport/exception/TransportClientGetException.java

@@ -22,6 +22,7 @@
 public class TransportClientGetException extends TransportException {
 
     private final String serverIp;
+    private final String causeMessage;
 
     /**
      * Constructor.
@@ -33,6 +34,7 @@ public TransportClientGetException(@NotNull String serverIp) {
         super(TransportErrorCodes.CLIENT_GET, serverIp);
 
         this.serverIp = serverIp;
+        this.causeMessage = null;
     }
 
     /**
@@ -43,17 +45,31 @@ public TransportClientGetException(@NotNull String serverIp) {
      * @since 1.2.0
      */
     public TransportClientGetException(@NotNull Throwable cause, @NotNull String serverIp) {
-        super(TransportErrorCodes.CLIENT_GET, cause, serverIp);
+        super(TransportErrorCodes.CLIENT_GET_WITH_CAUSE, cause, serverIp, cause.getMessage());
+
         this.serverIp = serverIp;
+        this.causeMessage = cause.getMessage();
     }
 
     /**
      * Gets the IP to which we wanted unsuccessfully to connect.
      *
      * @return The IP to which we wanted unsuccessfully to connect.
      * @since 1.2.0
+     * @deprecated Since 2.0.0. It was not renamed after copy-pasting from another class. Please make use of {@link #getServerIp()}.
      */
+    @Deprecated
     public String getRequestMessage() {
+        return getServerIp();
+    }
+
+    /**
+     * Gets the IP to which we wanted unsuccessfully to connect.
+     *
+     * @return The IP to which we wanted unsuccessfully to connect.
+     * @since 2.0.0
+     */
+    public String getServerIp() {
         return serverIp;
     }
 }

transport/api/src/main/java/org/eclipse/kapua/transport/exception/TransportClientPoolExhaustedException.java

@@ -57,7 +57,7 @@ public TransportClientPoolExhaustedException(@NotNull Throwable cause, @NotNull
      * @return The IP to which we wanted unsuccessfully to connect.
      * @since 2.0.0
      */
-    public String getRequestMessage() {
+    public String getServerIp() {
         return serverIp;
     }
 

transport/api/src/main/java/org/eclipse/kapua/transport/exception/TransportErrorCodes.java

@@ -27,6 +27,12 @@ public enum TransportErrorCodes implements KapuaErrorCode {
      */
     SEND_ERROR,
 
+    /**
+     * @see TransportSendException
+     * @since 2.0.0
+     */
+    SEND_ERROR_WITH_CAUSE,
+
     /**
      * @see TransportTimeoutException
      * @since 1.1.0
@@ -39,6 +45,12 @@ public enum TransportErrorCodes implements KapuaErrorCode {
      */
     CLIENT_GET,
 
+    /**
+     * @see TransportClientGetException
+     * @since 2.0.0
+     */
+    CLIENT_GET_WITH_CAUSE,
+
     /**
      * @see TransportClientPoolExhaustedException
      * @since 2.0.0

transport/api/src/main/java/org/eclipse/kapua/transport/exception/TransportSendException.java

@@ -23,16 +23,20 @@
  */
 public class TransportSendException extends TransportException {
 
-    private final TransportMessage requestMessage;
+    private final TransportMessage<?, ?> requestMessage;
+    private final String causeMessage;
 
     /**
      * Constructor.
      *
      * @param requestMessage The {@link TransportMessage} that we tried to send.
      * @since 1.1.0
      */
-    public TransportSendException(@NotNull TransportMessage requestMessage) {
-        this(null, requestMessage);
+    public TransportSendException(@NotNull TransportMessage<?, ?> requestMessage) {
+        super(TransportErrorCodes.SEND_ERROR, requestMessage);
+
+        this.requestMessage = requestMessage;
+        this.causeMessage = null;
     }
 
     /**
@@ -42,10 +46,11 @@ public TransportSendException(@NotNull TransportMessage requestMessage) {
      * @param requestMessage The {@link TransportMessage} that we tried to send.
      * @since 1.1.0
      */
-    public TransportSendException(@NotNull Throwable cause, @NotNull TransportMessage requestMessage) {
-        super(TransportErrorCodes.SEND_ERROR, cause, requestMessage);
+    public TransportSendException(@NotNull Throwable cause, @NotNull TransportMessage<?, ?> requestMessage) {
+        super(TransportErrorCodes.SEND_ERROR_WITH_CAUSE, cause, requestMessage, cause.getMessage());
 
         this.requestMessage = requestMessage;
+        this.causeMessage = cause.getMessage();
     }
 
     /**
@@ -54,7 +59,7 @@ public TransportSendException(@NotNull Throwable cause, @NotNull TransportMessag
      * @return The {@link TransportMessage} that we tried to send.
      * @since 1.1.0
      */
-    public TransportMessage getRequestMessage() {
+    public TransportMessage<?, ?> getRequestMessage() {
         return requestMessage;
     }
 }

transport/api/src/main/resources/transport-client-error-messages.properties

@@ -11,7 +11,9 @@
 #     Eurotech - initial API and implementation
 #
 ###############################################################################
-CLIENT_GET=Cannot get an instance of the transport client to connect to host: {0}
-CLIENT_POOL_EXHAUSTED=Cannot get an instance of the transport client to connect to host {0} within the configured timeout of {1}. This means that the pool is currently exhausted.
+CLIENT_GET=Cannot get an instance of the TransportClient to connect to host: {0}
+CLIENT_GET_WITH_CAUSE=Cannot get an instance of the TransportClient to connect to host: {0}. Caused by: {1}
+CLIENT_POOL_EXHAUSTED=Cannot get an instance of the TransportClient to connect to host {0} within the configured timeout of {1}ms
 SEND_ERROR=An error occurred when sending the message: {0}
+SEND_ERROR_WITH_CAUSE=An error occurred when sending the message: {0}. Caused by: {1}
 TIMEOUT=The request has not received a response within the timeout of: {0}ms